Skip to content
This repository has been archived by the owner on Nov 16, 2023. It is now read-only.

Potentially rename members of RoundingContext #19

Open
garrison opened this issue May 19, 2022 · 1 comment
Open

Potentially rename members of RoundingContext #19

garrison opened this issue May 19, 2022 · 1 comment
Labels
decision needed Decision needed rounding Related to QRAO rounding schemes

Comments

@garrison
Copy link
Member

What is the expected enhancement?

We've talked about renaming the following members of RoundingContext:

self.trace_values = trace_values # TODO: rename me
self.circuit = circuit # TODO: rename me

  • trace_values isn't really a standard term (they are really Pauli expectation values)
  • the circuit is really a state preparation circuit
@garrison garrison added decision needed Decision needed rounding Related to QRAO rounding schemes labels May 20, 2022
@garrison
Copy link
Member Author

I've thought about renaming trace_values to expvals, but it looks like either values or expectation_values would be preferred: Qiskit/qiskit#8100 (comment)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
decision needed Decision needed rounding Related to QRAO rounding schemes
Projects
None yet
Development

No branches or pull requests

1 participant