Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation for InstructionToSignals to be much more explicit #168

Closed
DanPuzzuoli opened this issue Dec 13, 2022 · 0 comments · Fixed by #177
Closed

Update documentation for InstructionToSignals to be much more explicit #168

DanPuzzuoli opened this issue Dec 13, 2022 · 0 comments · Fixed by #177
Assignees
Labels
documentation Improvements or additions to documentation
Milestone

Comments

@DanPuzzuoli
Copy link
Collaborator

DanPuzzuoli commented Dec 13, 2022

With #164 , we're working towards making the InstructionToSignals class behave in a way more reflective of how schedules are implemented on real backends. As this behaviour is non-obvious and non-trivial, after #164, we should update the documentation for this class to be much more explicit about the rules its following to generate the samples used in simulation from schedules.

@DanPuzzuoli DanPuzzuoli added the documentation Improvements or additions to documentation label Dec 13, 2022
@DanPuzzuoli DanPuzzuoli added this to the pulse sim v1 milestone Dec 13, 2022
@DanPuzzuoli DanPuzzuoli self-assigned this Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant