Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support additional data in DriverMetadata #574

Closed
5 tasks
mrossinek opened this issue Feb 23, 2022 · 1 comment · Fixed by #796
Closed
5 tasks

Support additional data in DriverMetadata #574

mrossinek opened this issue Feb 23, 2022 · 1 comment · Fixed by #796
Labels
status: need information Further information is requested type: enhancement

Comments

@mrossinek
Copy link
Member

mrossinek commented Feb 23, 2022

What is the expected enhancement?

#573 adds a workaround for the DriverMetadata object when passed through a transformer.

A useful enhancement would be to support additional data in this container which can store transformer-related information. This would serve the purpose of providing full information of how a certain driver result was obtained aiding in future reproducability.

A very crude idea would be to add string representations of the transformer instances which were applied to a given driver result. Then DriverMetadata could simply store a list of the applied transformers which a user could read and interpret in order to reproduce a certain result.

Here are some more specific implementation ideas:

  • implement BaseTransformer.__repr__(self) for all its subclasses
  • add a DriverMetadata.transformers: List[str] field and increment it's VERSION class attribute (if this get's done after Qiskit Nature 0.4 is released)
  • append the transformers repr(self) representation to the DriverMetadata.transformers list when transforming this object (see fix: catch DriverMetadata-related warnings during transform #573 for the code location where this would need to be added)
  • handle DriverMetadata.transformers during to_hdf5 and from_hdf5 of the DriverMetadata class (versioning needs to be handled if the VERSION had to be increased)
  • unittest all of the above
@mrossinek
Copy link
Member Author

I had this issue in my inbox again because somebody left a comment here which now appears to have been deleted.
Nonetheless, I wanted to leave a short update here, stating that the DriverMetadata is likely to undergo a significant re-design as part of #701 and #705. Thus, I will mark this issue as requiring more information and highly recommend anyone who would want to start on this, to first check in on the current status of its design 👍

@mrossinek mrossinek added the status: need information Further information is requested label Jun 20, 2022
@mrossinek mrossinek removed the good first issue Good for newcomers label Aug 3, 2022
@mrossinek mrossinek linked a pull request Aug 18, 2022 that will close this issue
3 tasks
@mergify mergify bot closed this as completed in #796 Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: need information Further information is requested type: enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant