Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate qiskit_nature.results #707

Closed
mrossinek opened this issue Jun 20, 2022 · 0 comments · Fixed by #746
Closed

Migrate qiskit_nature.results #707

mrossinek opened this issue Jun 20, 2022 · 0 comments · Fixed by #746
Labels
type: feature request New feature or request
Milestone

Comments

@mrossinek
Copy link
Member

What should we add?

As part of #701, all existing modules of Qiskit Nature will be migrated.
This issue outlines the requirements for the existing results module.
This issue is blocked by #706.

⚠️ This migration needs to copy the code in order to abide the deprecation process!

Below are the current module contents:

qiskit_nature/
    results/
        BopesSamplerResult
        EigenstateResult
        ElectronicStructureResult
        LatticeModelResult
        ProteinFoldingResult
        VibrationalStructureResult

Here are the new locations for all of these classes.

qiskit_nature/
    second_quantization/
        problems/
            EigenstateResult
            electronic/
                ElectronicStructureResult
            lattice/
                LatticeModelResult
            vibrational/
                VibrationalStructureResult

Unittests should be migrated accordingly.

The classes BopesSamplerResult and ProteinFoldingResult can be ignored for the time being.

This will be updated later!

@mrossinek mrossinek added the type: feature request New feature or request label Jun 20, 2022
@mrossinek mrossinek added this to the 0.5.0 milestone Jun 20, 2022
@mrossinek mrossinek linked a pull request Jul 18, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature request New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant