Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong Layout Preview #794

Closed
mrsendyyk opened this issue Aug 20, 2020 · 4 comments
Closed

Wrong Layout Preview #794

mrsendyyk opened this issue Aug 20, 2020 · 4 comments

Comments

@mrsendyyk
Copy link
Contributor

mrsendyyk commented Aug 20, 2020

Based on PR #9993 and PR #10030 on qmk/qmk_firmware, i try to check LAYOUT_60_ansi_arrow for DZ60:

DZ60

And LAYOUT_numpad_5x4 ai03 Soyuz on QMK Configurator.

Soyuz

But i think the layout preview are wrong.

Are there something wrong with my PR's? Or did I miss something?

Can you help me @fauxpark, @noroadsleft, @zvecr, or anyone for fixing that wrong layout preview.

Thank you.

@mrsendyyk mrsendyyk changed the title DZ60 LAYOUT_60_ansi_arrow & ai03 Soyuz LAYOUT_numpad_5x4 Layout Preview Aug 20, 2020
@mrsendyyk mrsendyyk changed the title Layout Preview Wrong Layout Preview Aug 20, 2020
@fauxpark
Copy link
Member

You need to add those layouts into the info.json.

@greenjack-z
Copy link
Contributor

I have an issue with the layout of my (zergo) keyboard - layout done in info.json tells to configurator the right view of the keys. But looks like it use it to get the rows\cols at the PCB as well. But rows at PCB not straight and not 100% aligned with physical keyboard - so after compilation keys displaced. Seems like it should be different files for preview and for PCB layout.

@fauxpark
Copy link
Member

The info.json only provides the physical layout of the keys for rendering in Configurator, and the ordering of the keys per the top half of the LAYOUT macro(s).

@mrsendyyk
Copy link
Contributor Author

You need to add those layouts into the info.json.

Ah i see, thank you @fauxpark, i will try to fixed that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants