Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] MK_COMBINED broken after PR #11804 #12241

Closed
uqs opened this issue Mar 14, 2021 · 2 comments
Closed

[Bug] MK_COMBINED broken after PR #11804 #12241

uqs opened this issue Mar 14, 2021 · 2 comments

Comments

@uqs
Copy link

uqs commented Mar 14, 2021

Describe the Bug

  1. Have #define MK_COMBINED in your config.h, as you like to use KC_ACL0 et al. when mousing
  2. Build is broken:
Compiling: quantum/mousekey.c                                                                      quantum/mousekey.c: In function ‘move_unit’:
quantum/mousekey.c:135:35: error: ‘mouse_timer’ undeclared (first use in this function)
  135 |     } else if (mousekey_repeat && mouse_timer) {
      |                                   ^~~~~~~~~~~
quantum/mousekey.c:135:35: note: each undeclared identifier is reported only once for each function it appears in
quantum/mousekey.c: At top level:
quantum/mousekey.c:149:7: error: conflicting types for ‘mk_wheel_interval’
  149 | float mk_wheel_interval = 1000.0f / MOUSEKEY_WHEEL_INITIAL_MOVEMENTS;
      |       ^~~~~~~~~~~~~~~~~
quantum/mousekey.c:68:9: note: previous definition of ‘mk_wheel_interval’ was here
   68 | uint8_t mk_wheel_interval    = MOUSEKEY_WHEEL_INTERVAL;
      |         ^~~~~~~~~~~~~~~~~
quantum/mousekey.c: In function ‘wheel_unit’:
quantum/mousekey.c:156:35: error: ‘mouse_timer’ undeclared (first use in this function)
  156 |     } else if (mousekey_repeat && mouse_timer) {
      |                                   ^~~~~~~~~~~
 [ERRORS]

Patching things up to get them to compile is easy enough but results in a pointer that is way too slow.

Additional Context

Was working fine before, though I didn't actually bisect, but the PR and merge seem like obvious culprits.

@zvecr
Copy link
Member

zvecr commented Apr 13, 2021

image

Given the contents of #11804, I doubt that it introduced your issue.

@uqs
Copy link
Author

uqs commented Apr 13, 2021

Sigh, sorry for the noise. Not sure what git blame I used to come up with this, and the good news is that this no longer reproduces,

@uqs uqs closed this as completed Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants