Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Keymap compilation warning #19467

Closed
1 of 4 tasks
elpekenin opened this issue Jan 1, 2023 · 2 comments
Closed
1 of 4 tasks

[Feature Request] Keymap compilation warning #19467

elpekenin opened this issue Jan 1, 2023 · 2 comments
Labels
enhancement help wanted stale Issues or pull requests that have become inactive without resolution.

Comments

@elpekenin
Copy link
Contributor

Feature Request Type

  • Core functionality
  • Add-on hardware support (eg. audio, RGB, OLED screen, etc.)
  • Alteration (enhancement/optimization) of existing feature(s)
  • New behavior

Description

When compiling a keymap whose folder contains both keymap.json and keymap.c, json takes precedence without any warning (which isn't consistent with the way info.json vs c/h works, so i was expecting it to work the other way around)

I tried fixing it, but looking at the compile.py I'm pretty sure it only builds and runs the make command and couldn't figure out neither
a) How to check if both files exist
b) How to print a warning-formatted string

Line 157 on builddefs/build_keyboard.mk is checking if the keymap.json exists, could maybe add another if on that block to check if .c exists too, and throw a warning similar to the ones like "info.json configuration will be override by config/rules"
I would write it if I had any knowledge about mk but I guess it will be pretty much trivial for someone who knows

I dont have any idea on which of the two should take precedence, but the warning would definitely avoid some headaches

@github-actions
Copy link

github-actions bot commented Apr 2, 2023

This issue has been automatically marked as stale because it has not had activity in the last 90 days. It will be closed in the next 30 days unless it is tagged properly or other activity occurs.
For maintainers: Please label with bug, in progress, on hold, discussion or to do to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Apr 2, 2023
@github-actions
Copy link

github-actions bot commented May 3, 2023

This issue has been automatically closed because it has not had activity in the last 30 days. If this issue is still valid, re-open the issue and let us know.
// [stale-action-closed]

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement help wanted stale Issues or pull requests that have become inactive without resolution.
Projects
None yet
Development

No branches or pull requests

1 participant