You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Add-on hardware support (eg. audio, RGB, OLED screen, etc.)
Alteration (enhancement/optimization) of existing feature(s)
New behavior
Description
When compiling a keymap whose folder contains both keymap.json and keymap.c, json takes precedence without any warning (which isn't consistent with the way info.json vs c/h works, so i was expecting it to work the other way around)
I tried fixing it, but looking at the compile.py I'm pretty sure it only builds and runs the make command and couldn't figure out neither
a) How to check if both files exist
b) How to print a warning-formatted string
Line 157 on builddefs/build_keyboard.mk is checking if the keymap.json exists, could maybe add another if on that block to check if .c exists too, and throw a warning similar to the ones like "info.json configuration will be override by config/rules"
I would write it if I had any knowledge about mk but I guess it will be pretty much trivial for someone who knows
I dont have any idea on which of the two should take precedence, but the warning would definitely avoid some headaches
The text was updated successfully, but these errors were encountered:
This issue has been automatically marked as stale because it has not had activity in the last 90 days. It will be closed in the next 30 days unless it is tagged properly or other activity occurs.
For maintainers: Please label with bug, in progress, on hold, discussion or to do to prevent the issue from being re-flagged.
This issue has been automatically closed because it has not had activity in the last 30 days. If this issue is still valid, re-open the issue and let us know.
// [stale-action-closed]
Feature Request Type
Description
When compiling a keymap whose folder contains both
keymap.json
andkeymap.c
,json
takes precedence without any warning (which isn't consistent with the wayinfo.json
vsc
/h
works, so i was expecting it to work the other way around)I tried fixing it, but looking at the
compile.py
I'm pretty sure it only builds and runs themake
command and couldn't figure out neithera) How to check if both files exist
b) How to print a warning-formatted string
Line 157 on
builddefs/build_keyboard.mk
is checking if thekeymap.json
exists, could maybe add anotherif
on that block to check if.c
exists too, and throw a warning similar to the ones like "info.json configuration will be override by config/rules"I would write it if I had any knowledge about
mk
but I guess it will be pretty much trivial for someone who knowsI dont have any idea on which of the two should take precedence, but the warning would definitely avoid some headaches
The text was updated successfully, but these errors were encountered: