Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACTION_TAP_DANCE_LAYER_TOGGLE doesn't work? #7121

Closed
dky opened this issue Oct 23, 2019 · 3 comments
Closed

ACTION_TAP_DANCE_LAYER_TOGGLE doesn't work? #7121

dky opened this issue Oct 23, 2019 · 3 comments

Comments

@dky
Copy link

dky commented Oct 23, 2019

I'm trying to define leverage the ACTION_TAP_DANCE_LAYER_TOGGLE but it's not working for me. I'm basically using it as so:

[TD_DVORAK] = ACTION_TAP_DANCE_LAYER_TOGGLE(KC_1, 2)

Which should send a number 1 or toggle to layer 2 if double tapped. However during compilation I get:

Compiling: keyboards/kinesis/keymaps/dky/keymap.c keyboards/kinesis/keymaps/dky/keymap.c:134:16: error: implicit declaration of function 'ACTION_TAP_DANCE_LAYER_TOGGLE'; did you mean 'ACTION_TAP_DANCE_DUAL_ROLE'? [-Werror=implicit-function-declaration]
[TD_DVORAK] = ACTION_TAP_DANCE_LAYER_TOGGLE(KC_1, layer),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
ACTION_TAP_DANCE_DUAL_ROLE
keyboards/kinesis/keymaps/dky/keymap.c:134:52: error: 'layer' undeclared here (not in a function)
[TD_DVORAK] = ACTION_TAP_DANCE_LAYER_TOGGLE(KC_1, layer),
^~~~~
cc1: all warnings being treated as errors
[ERRORS]

Can someone please chime in on what I'm doing wrong?

@fauxpark
Copy link
Member

Looks like the documentation is incorrect and the actual name for that Tap Dance action is ACTION_TAP_DANCE_TOGGLE_LAYER, not LAYER_TOGGLE. Additionally I think you are not filling in the layer argument - it has to be a constant value.

@noroadsleft
Copy link
Member

@fauxpark Looks like you and I both missed this on #6629. 😊 It should have been changed as documented. 🤦‍♂️

@dky
Copy link
Author

dky commented Oct 23, 2019

Hey guys, disregard my last reply, deleted it, I got it to work by pulling the lastest master. Thank you both for your assistance on this!

@dky dky closed this as completed Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants