Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request | Docs] Add MIDI keycodes to the Full List of Keycodes #9868

Closed
4 tasks
precondition opened this issue Jul 29, 2020 · 4 comments
Closed
4 tasks

Comments

@precondition
Copy link
Contributor

Addition to the documentation

  • Core functionality
  • Add-on hardware support (eg. audio, RGB, OLED screen, etc.)
  • Alteration (enhancement/optimization) of existing feature(s)
  • New behavior

Description

The full list of keycodes is missing all the MIDI keycodes found here in the quantum_keycode.h file.

I'd submit a PR myself but I am not familiar at all with MIDI or music in general, really, so I won't be able to write a description of all those keycodes.

@stale
Copy link

stale bot commented Oct 28, 2020

This issue has been automatically marked as stale because it has not had activity in the last 90 days. It will be closed in the next 30 days unless it is tagged properly or other activity occurs.
For maintainers: Please label with bug, in progress, on hold, discussion or to do to prevent the issue from being re-flagged.

@stale stale bot added the stale Issues or pull requests that have become inactive without resolution. label Oct 28, 2020
@stale
Copy link

stale bot commented Nov 27, 2020

This issue has been automatically closed because it has not had activity in the last 30 days. If this issue is still valid, re-open the issue and let us know.

@stale stale bot closed this as completed Nov 27, 2020
@fauxpark fauxpark reopened this Nov 28, 2020
@stale stale bot removed the stale Issues or pull requests that have become inactive without resolution. label Nov 28, 2020
@fauxpark fauxpark self-assigned this Nov 28, 2020
@fauxpark fauxpark added the to do label Nov 28, 2020
@wxyangf
Copy link

wxyangf commented Jun 5, 2021

I'll take a look at this after the main MIDI doc issue has been merged

@fauxpark
Copy link
Member

Looks like this has been fixed by the above PR. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants