Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Swap Hands feature outright broken #9967

Closed
3 tasks
drashna opened this issue Aug 7, 2020 · 0 comments · Fixed by #9968
Closed
3 tasks

[Bug] Swap Hands feature outright broken #9967

drashna opened this issue Aug 7, 2020 · 0 comments · Fixed by #9968
Assignees
@drashna
Labels
bug help wanted

Comments

@drashna
Copy link
Member

drashna commented Aug 7, 2020 •
edited
Loading

Describe the Bug

Use any of the swap hands keycodes, and they simply don't work. This is even with boards that I can personally confirm were working.

System Information

  • Keyboard: ErgoDox EZ (known working previously), Moonlander
  • Operating system: MacOS
  • AVR GCC version: 8.4.0
  • ARM GCC version: 8.3.1
  • QMK Firmware version: 0.9.47
  • Any keyboard related software installed?
    • AutoHotKey
    • Karabiner
    • Other:

Additional Context

I believe that this may have been broken by the "force oneshot cleanup" code change.

May be related to #9056

Tracked down to this commit: #8590
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@drashna drashna

Labels
bug help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Bugfix] Fix Swap Hands bug introduced by OSH qmk/qmk_firmware
1 participant
@drashna