-
Notifications
You must be signed in to change notification settings - Fork 745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request] Support for custom templating for "/describe" #213
Comments
Yes! I've been thinking about similar things. Many of our repos include a The short-code expansion is also interesting. This is similar to the "markers" that Copilot for Pull Requests uses. |
agreed! this will be great! |
I will also add an option to template the title of the PR, again, we always add the related ticket number to the PR title, and the |
You are welcome to open a PR for the 'describe' tool with the option to set a dedicated title, or add a dedicated extra section: Something like: @tjwp regarding your suggestion about reading and using a dedicated template, it is more complicated to get this kind of thing to work reliably. Templates can be large and complicated, and it also make it harder to use of a custom json. you are welcome to try and share a tool. Look at the 'update_changelog' tool for inspiration, it does something similar (reads the current changelog file, and uses its current style to update the changelog) |
I spotted a possible problem with the |
I'm not sure when it was added but I found the "pr_description.add_original_user_description" and "pr_description.keep_original_user_title" PR agent config options and it's helping a lot with this issue. Example:
Github Action version (defaulting "add_original_user_description" as true for repo using
Some kind of templating / short-code expansion support would still be useful for more advanced customization but these options are helping a lot already! |
I've been running the "/describe" on a lot of PRs, and the output is excellent. With reviews automatically being created by the PR Agent, this one has been my primary shortcut. One usability issue I'm running into, however, is that the "/describe" replaces the entire PR description section and title.
The "/describe -c" option for posting the description as a comment works as expected, but what I'd really like to do is automate the process of manually filling out Github pull request templates.
For a possible implementation, it seems like trying to automatically map the LLM response to a dynamically configured pull request template would have too many edge cases. Instead, what if there was support for short-code or variable expansion mechanisms such as:
pr_agent:describe
, and then the AI could substitute the variable with the description?The text was updated successfully, but these errors were encountered: