Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Low exists performance on single key requests #585

Closed
ikopylov opened this issue Aug 25, 2022 · 1 comment · Fixed by #634
Closed

Low exists performance on single key requests #585

ikopylov opened this issue Aug 25, 2022 · 1 comment · Fixed by #634
Assignees
@lostl1ght
Labels
improvement performance

Comments

@ikopylov
Copy link
Member

ikopylov commented Aug 25, 2022 •
edited
Loading

Roughly ~1.5 times slower than get
@ikopylov
Copy link
Member Author

This is obvious because exists does not handle requests for node local data in a special way: https://github.com/qoollo/bob/blob/master/bob/src/cluster/quorum.rs#L221

@lostl1ght lostl1ght mentioned this issue Oct 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lostl1ght lostl1ght

Labels
improvement performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

576, 585 lookup existence in aliens, separate remote & local lookup qoollo/bob
2 participants
@ikopylov @lostl1ght