Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

High performance degradation on HierarchicalFilters update in Group::put #596

Closed
ikopylov opened this issue Aug 30, 2022 · 1 comment · Fixed by #770
Closed

High performance degradation on HierarchicalFilters update in Group::put #596

ikopylov opened this issue Aug 30, 2022 · 1 comment · Fixed by #770

Comments

@ikopylov
Copy link
Member

ikopylov commented Aug 30, 2022

Performance degrade from 25000 RPS to 10000 RPS.
This can be connected with write lock acquisition or be a problem in add_to_parents.

https://github.com/qoollo/bob/blob/master/bob-backend/src/pearl/group.rs#L228

@ikopylov ikopylov added bug Something isn't working performance improvement and removed bug Something isn't working labels Aug 30, 2022
@ikopylov
Copy link
Member Author

This is definetely due to the write lock acquisition. The operation under write lock does not change the collection structure, thus it can be a read lock. Actual update happened only in filters inside, so there should be an additional lock inside HierarchicalFilters that control access to actual filters

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants