Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce node ping timeout to speed-up disconnect detection #805

Open
ikopylov opened this issue May 23, 2023 · 0 comments · May be fixed by #835
Open

Reduce node ping timeout to speed-up disconnect detection #805

ikopylov opened this issue May 23, 2023 · 0 comments · May be fixed by #835
Assignees

Comments

@ikopylov
Copy link
Member

ikopylov commented May 23, 2023

Right now ping timeout is equal to operation timeout. We can reduce timeout for ping, because it does not perform any action on target node. This will allow to detect node disconnect faster. This timeout parameter should be added to config (check_timeout).

Additionally, it would be good to perform ping in parallel with FuturesUnordered. Right now it iterates nodes one-by-one: https://github.com/qoollo/bob/blob/master/bob/src/link_manager.rs#L61

@idruzhitskiy idruzhitskiy linked a pull request Sep 7, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants