Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple problems in a request that adds support for multiple replicas on the same node #837

Open
ikopylov opened this issue Sep 22, 2023 · 1 comment · May be fixed by #838
Open

Multiple problems in a request that adds support for multiple replicas on the same node #837

ikopylov opened this issue Sep 22, 2023 · 1 comment · May be fixed by #838
Assignees
Labels
bug Something isn't working

Comments

@ikopylov
Copy link
Member

  1. at_least is not reduced by the number of local copies when requests are made simultaneously to local and remote nodes: https://github.com/qoollo/bob/blob/master/bob/src/cluster/quorum.rs#L44
  2. warn log instead of trace in finish_at_least_handles (previously it was trace): https://github.com/qoollo/bob/blob/master/bob/src/cluster/operations.rs#L65
  3. put_remote_nodes always run put_at_least even when the list of target_nodes is empty: https://github.com/qoollo/bob/blob/master/bob/src/cluster/quorum.rs#L135
@ikopylov ikopylov added the bug Something isn't working label Sep 22, 2023
@ikopylov
Copy link
Member Author

With the first problem: it results in waiting for a response from more nodes than necessary. If at_least will be reduced, then additional finish_at_least_handles call will be required in the case the local put failed

@idruzhitskiy idruzhitskiy linked a pull request Sep 23, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants