Problem with Webminstats

[Feliksas]

Greetings,
There's a problem with displaying Webminstats panorama, while this theme is active.
Should be:
http://3.bp.blogspot.com/-KHEcs0TlcIE/U_pUN44P0yI/AAAAAAAAULM/sFXVnMev2So/s1600/Screen%2BShot%2B2014-08-24%2Bat%2B22.06.18.png

Actual situation:
https://yadi.sk/i/S1x1sKBebiTVz

This module is 3rd-party, but can be installed from within Webmin itself (Webmin Modules/Install/Third party module from: "webminstat")

[iliajie]

I have checked Webminstats module. It's true that there is no images in panorama. Even though graphs are shown just fine, as you later click on the correspondent link.

There is a problem fixing that - because, it's not really a problem of Authentic.

Webminstats builds/draws graphs/images based on default theme engine, which is totally wrong. Webminstats relies on one part of the code, from the old themes, that I have just intentionally removed.

I would suggest referring with this problem to the developers and asking them to change the way their module interacts with the theme. The way it's build now, is not very flexible/right and should be fixed for preventing future incompatibility issues.

There is not much I can do here. I'm sorry, pal.

[iliajie]

Added basic support for this module. Will be supported in Authentic Theme v.8.0.0.

[gerbier]

I am the author of webminstats module. I am using the icons_table call (from core api) to display aligned graphs, what's wrong with this ? (I had a look at others modules, and it seems to common).
Can you provide a documentation link ?

[iliajie]

Hello! Thanks for contacting.

I'm not using the part of the code that generates icons. But in the recent version I have made a work around for your module.

You can see the way theme works by simply installing it and looking at authentic.pl.

[gerbier]

Hello,

Yes, I can install it on an ubuntu 14.10.
And yesterday, I had a look at ui-lib (which does not exists when webminstats was first coded) :
in next release, I will try to replace my code by ui_* functions. It should work better with themes.

----- Mail original -----

Hello! Thanks for contacting.

I'm not using the part of the code that generates icons. But in the
recent version I have made a work around for your module.

You can see the way theme works by simply installing it and looking
at authentic.pl .

—
Reply to this email directly or view it on GitHub .

[iliajie]

Great, thanks!

[gerbier]

Hello

I just release today a new version of webminstats (2.11) which works well with authentic theme, without any workaround in your code.
You will be able to remove this code when you want.

regards,

----- Mail original -----

Hello! Thanks for contacting.

I'm not using the part of the code that generates icons. But in the
recent version I have made a work around for your module.

You can see the way theme works by simply installing it and looking
at authentic.pl .

—
Reply to this email directly or view it on GitHub .

[iliajie]

Perfect, I'll check, thanks, pal!

[iliajie]

@gerbier Please take a look: #889 (comment)