Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem after update (virtual-server::list_system_info failed line 3617) (Fixed) #211

Closed
Goeny opened this issue Jul 30, 2015 · 28 comments
Closed
Labels

Comments

@Goeny
Copy link

Goeny commented Jul 30, 2015

I just updated to v14.01 (or something like that) And the system info page won't load anymore.
Now i get the following message.. How should i fix this? (or how to revert to v14.0)

virtual-server::list_system_info failed : Undefined subroutine &net::active_interfaces called at /usr/share/webmin/virtual-server/virtual-server-lib-funcs.pl line 3617.

@iliajie iliajie changed the title Problem after update Problem after update (virtual-server::list_system_info failed line 3617) Jul 30, 2015
@iliajie
Copy link
Collaborator

iliajie commented Jul 30, 2015

You probably edited those files manually? At the moment I have no clue and based on the error message it seems that it's not theme related? Tried to restart Webmin?

Are you installing Webmin from the repo or using package manager? What OS you're on and how do you upgrade?

@HansKristoffer
Copy link

I have exactly the same problem as Goeny after update

@elaphos
Copy link

elaphos commented Jul 30, 2015

Same here. Updated two servers, one Debian 6 the other Debian 7

@iliajie
Copy link
Collaborator

iliajie commented Jul 30, 2015

Restart Webmin!

@elaphos
Copy link

elaphos commented Jul 30, 2015

Restarting Webmin didn't help. Going back to 14.0...

@iliajie
Copy link
Collaborator

iliajie commented Jul 30, 2015

Is this only happening on System Information page?

@HansKristoffer
Copy link

Yes

@elaphos
Copy link

elaphos commented Jul 30, 2015

Not only System Information:

Webmin: Network -> Linux Firewall: Undefined subroutine &net::boot_interfaces called at debian-linux-lib.pl line 121.

Virtualmin: Backup & Restore -> Restore Backup: Undefined subroutine &net::active_interfaces called at /usr/share/webmin/virtual-server/virtual-server-lib-funcs.pl line 3617.

Virtualmin: Add Servers -> Import Virtual Server: Undefined subroutine &net::active_interfaces called at /usr/share/webmin/virtual-server/virtual-server-lib-funcs.pl line 3617.

Vitualmin: List Virtual Servers: Undefined subroutine &net::active_interfaces called at /usr/share/webmin/virtual-server/virtual-server-lib-funcs.pl line 3617.

@iliajie
Copy link
Collaborator

iliajie commented Jul 30, 2015

You will be surprised to know, that I haven't changed sysinfo.cgi since last update.

Your error has nothing to do with the theme. Change to default theme and you should experience that same issue, I bet!

How and when did you install/update Webmin?

@Goeny
Copy link
Author

Goeny commented Jul 30, 2015

I actually switched theme... Problem is not there with other themes.
Installed virtualmin with install.sh on Debian 7.
Already restarted webmin, didnt help.

@elaphos
Copy link

elaphos commented Jul 30, 2015

Bet lost! ;)

authentic-theme 14.0 and Virtualmin Framed Theme are ok

Both server installed via Virtualmin GPL install.sh script and updated via package manager.

One (Debian 6) two years ago, Webmin 1.760/Virtualmin 4.17
the other (Debian 7) 7.7.2015, Webmin 1.760/Virtualmin 4.18

@iliajie
Copy link
Collaborator

iliajie commented Jul 30, 2015

Hmm. :) Will see. Let me take a look again! I will post a bit later.

@iliajie
Copy link
Collaborator

iliajie commented Jul 30, 2015

  1. Did you recently pull from Webmin repo?
  2. How did you upgrade/install the theme?
  3. What is the output of ls -lsaZ /usr/share/webmin/authentic-theme

Jamie few days ago updated Webmin net module. It seems to me that you've pull from the Webmin repo, maybe?

@specktator
Copy link

Guys its all fine from Ubuntu 14.04.2 LTS , authentic 14.01 and Webmin 1.760 ... cleared cache memory etc... restared Webmin .... just fine from my side.

@iliajie
Copy link
Collaborator

iliajie commented Jul 30, 2015

The error from virtual-server.lib.funcs.pl, line 3617, says that there is no method active_interfaces on class net.

# From interface detected at check time
    &foreign_require("net", "net-lib.pl");
    local $ifacename = $config{'iface'} || &first_ethernet_iface();
    local ($iface) = grep { $_->{'fullname'} eq $ifacename }
                  &net::active_interfaces();
    if ($iface) {
        return $iface->{'address'};
        }
    else {
        return undef;
        }
    }

Tell me how does it tie to Authentic Theme?

@iliajie
Copy link
Collaborator

iliajie commented Jul 30, 2015

Hm. If you running Debian, actually you could experience this problem, as net/debian-linux-lib.pl doesn't really have this (active_interfaces) method.

I would say, that you should have faced this issue long before. Will notify Joe.

@elaphos
Copy link

elaphos commented Jul 30, 2015

Strange... But what could trigger this issue? Tried a third server (Debian 6) same behaviour: Other themes and 14.0 work fine, 14.01 -> throws this active_interfaces error

@iliajie
Copy link
Collaborator

iliajie commented Jul 30, 2015

What is the output on authentic-theme folder of ls -lsaZ command?

@iliajie
Copy link
Collaborator

iliajie commented Jul 30, 2015

No, this method is there, my bad, as debian-linux-lib.pl pulls linux-lib.pl.

What is causing it? I have no clue yet. I'm not at the machine.

I will ask again, please:

  1. Did you recently pull from Webmin repo?
  2. How did you upgrade/install the theme?
  3. What is the output of ls -lsaZ /usr/share/webmin/authentic-theme (or whereever your theme folder is)

@cooperdk
Copy link

I have it too, qooob.

It is 100% certainly an error in 14.01.

14.00 and later work FINE. I just tested the last three versions.

All other themes work FINE. The original, virtualmin framed, and the bwtheme (bootstrap).

I both tried upgrading and installing manually. The error is the same no matter how 14.01 is applied.

----- REASON

cron job scheduled_collect_system_info fails with:

failed : system-status::scheduled_collect_system_info failed : Undefined subroutine &net::active_interfaces called at /usr/share/webmin/system-status/system-status-lib.pl line 172.

===== Output of ls command

root@*******:~# ls -lsaZ /usr/share/webmin/authentic-theme
total 292
4 drwxrwxrwx 6 root root ? 4096 Jul 31 05:45 .
20 drwxr-xr-x 138 root root ? 20480 Jul 31 05:45 ..
60 -rwxrwxrwx 1 root root ? 58872 Jul 31 05:45 authentic-lib.cgi
44 -rwxrwxrwx 1 root root ? 43327 May 31 12:24 authentic.pl
4 drwxrwxrwx 2 root root ? 4096 May 31 12:24 .build
4 -rwxrwxrwx 1 root root ? 2584 Jul 31 05:45 buttons.cgi
32 -rwxrwxrwx 1 root root ? 31097 May 31 12:24 CHANGELOG.md
8 -rwxrwxrwx 1 root root ? 7212 May 31 12:24 changelog.pl
4 -rwxrwxrwx 1 root root ? 116 May 31 12:24 config
4 drwxrwxrwx 3 root root ? 4096 May 31 12:24 images
12 -rwxrwxrwx 1 root root ? 11323 Jul 31 05:45 index.cgi
4 drwxrwxrwx 2 root root ? 4096 May 31 12:24 lang
4 -rwxrwxrwx 1 root root ? 1084 May 31 12:24 LICENSE
8 -rwxrwxrwx 1 root root ? 6783 Jul 31 05:45 navigation.cgi
8 -rwxrwxrwx 1 root root ? 7438 May 31 12:24 README.md
8 -rwxrwxrwx 1 root root ? 6421 Jul 31 05:45 session_login.cgi
4 -rwxrwxrwx 1 root root ? 732 Jul 31 05:45 settings.cgi
4 -rwxrwxrwx 1 root root ? 2441 Jul 31 05:45 settings-editor_read.cgi
4 -rwxrwxrwx 1 root root ? 655 Jul 31 05:45 settings-editor_write.cgi
8 -rwxrwxrwx 1 root root ? 7347 Jul 31 05:45 settings-upload.cgi
4 -rwxrwxrwx 1 root root ? 2614 Jul 31 05:45 settings-upload_save.cgi
28 -rwxrwxrwx 1 root root ? 26619 Jul 31 05:45 sysinfo.cgi
4 -rwxrwxrwx 1 root root ? 197 May 31 12:24 theme.info
4 drwxrwxrwx 5 root root ? 4096 May 31 12:24 unauthenticated
4 -rwxrwxrwx 1 root root ? 6 May 31 12:24 VERSION.txt

@elaphos
Copy link

elaphos commented Jul 31, 2015

  1. No pulls from repo, all updates via apt-get
  2. Tried both: Update button and a fresh install from authentic-theme-latest.wbt.gz (deleted the whole "authentic-theme"directory before)

insgesamt 292
4 drwxr-xr-x 5 root root ? 4096 Jul 31 00:33 .
20 drwxr-xr-x 133 root root ? 20480 Jul 31 00:33 ..
64 -rwxr-xr-x 1 root root ? 64156 Jul 31 00:33 authentic-lib.cgi
40 -rwxr-xr-x 1 root root ? 38156 Jul 21 16:43 authentic.pl
4 -rwxr-xr-x 1 root root ? 2584 Jul 31 00:33 buttons.cgi
36 -rw-r--r-- 1 root root ? 34036 Jul 21 18:20 CHANGELOG.md
8 -rwxr-xr-x 1 root root ? 6147 Jul 21 19:08 changelog.pl
4 -rw-r--r-- 1 root root ? 118 Jul 19 22:51 config
4 drwxr-xr-x 3 root root ? 4096 Jul 21 18:25 images
12 -rwxr-xr-x 1 root root ? 11242 Jul 31 00:33 index.cgi
4 drwxr-xr-x 2 root root ? 4096 Jun 30 12:02 lang
4 -rw-r--r-- 1 root root ? 1082 Jul 19 22:52 LICENSE
8 -rwxr-xr-x 1 root root ? 6841 Jul 31 00:33 navigation.cgi
8 -rw-r--r-- 1 root root ? 7736 Jul 21 19:10 README.md
8 -rwxr-xr-x 1 root root ? 6715 Jul 31 00:33 session_login.cgi
4 -rwxr-xr-x 1 root root ? 732 Jul 31 00:33 settings.cgi
4 -rwxr-xr-x 1 root root ? 2441 Jul 31 00:33 settings-editor_read.cgi
4 -rwxr-xr-x 1 root root ? 737 Jul 31 00:33 settings-editor_write.cgi
8 -rwxr-xr-x 1 root root ? 7347 Jul 31 00:33 settings-upload.cgi
4 -rwxr-xr-x 1 root root ? 3183 Jul 31 00:33 settings-upload_save.cgi
28 -rwxr-xr-x 1 root root ? 28479 Jul 31 00:33 sysinfo.cgi
4 -rw-r--r-- 1 root root ? 199 Jul 19 22:52 theme.info
4 drwxr-xr-x 5 root root ? 4096 Jul 18 00:59 unauthenticated
4 -rw-r--r-- 1 root root ? 6 Jul 19 22:52 VERSION.txt

@iliajie
Copy link
Collaborator

iliajie commented Jul 31, 2015

I can't believe to what I'm seeing and why actually Perl didn't fail. This is horrible.

I simply placed parenthesis in the wrong place that I would expect to fail in any programming language but it worked in Perl taking the error to the other place?

I will ask Joe or Jamie about this as it's completely rediculus. Probably it's the Perl bug.

Was:
index( $ENV{'REQUEST_URI'}, '/virtual-server/history.cgi' != -1 )

Has to be:
index( $ENV{'REQUEST_URI'}, '/virtual-server/history.cgi' ) != -1

I will do the update in few minutes.

@iliajie
Copy link
Collaborator

iliajie commented Jul 31, 2015

Alright, guys, please upgrade! Version 14.02 should fix this bug. Very sorry about this and thanks for pointing out!!

Could you please report your Perl versions?

@elaphos
Copy link

elaphos commented Jul 31, 2015

Working! 👍
Perl v5.10.1 (Debian 6)
Perl v5.14.2 (Debian 7)

@iliajie
Copy link
Collaborator

iliajie commented Jul 31, 2015

I see!! Great! That is so wrong that it passed compilation on my machines.

I got Perl v5.20.2

@Goeny
Copy link
Author

Goeny commented Jul 31, 2015

Sorry for the late reply...
Fixed with new update! Thank you!!

I am on Perl 5.14.2 (Debian 7)

@iliajie iliajie added the bug label Jul 31, 2015
@iliajie iliajie changed the title Problem after update (virtual-server::list_system_info failed line 3617) Problem after update (virtual-server::list_system_info failed line 3617) (Fixed) Jul 31, 2015
@cooperdk
Copy link

I have Perl v5.14.2 too

The 14.02 update fixed the issue for me, too. Thanks! :-)

@iliajie
Copy link
Collaborator

iliajie commented Jul 31, 2015

You are welcome, guys! Good luck! ;)

Thanks for reporting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants