Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text Areas and Line Numbers #356

Closed
SteffanCline opened this issue Jan 27, 2016 · 11 comments
Closed

Text Areas and Line Numbers #356

SteffanCline opened this issue Jan 27, 2016 · 11 comments

Comments

@SteffanCline
Copy link

The areas where you have text area with line numbers like when manually editing a BIND zone, the font should be a monospaced font. Your styling doesn't properly show tabs so a tab is converted to a white space.

@iliajie
Copy link
Collaborator

iliajie commented Jan 27, 2016

In default theme was there monospace font in default textarea?

@SteffanCline
Copy link
Author

Yes. All tabs were preserved.

@davenir
Copy link

davenir commented Jan 28, 2016

I don't know if this is related but I'm seeing strange characters in editors and in the browser title also. I didn't have this on previous theme. Love this new theme though.

screen shot 012
screen shot 013
screen shot 014

@iliajie
Copy link
Collaborator

iliajie commented Jan 28, 2016

Read front page of the repo. You need to set UTF8.

After you change the encoding does it solve your initial issue?

@davenir
Copy link

davenir commented Jan 28, 2016

Thanks Ilya - I did this but it made no difference in Virtualmin.
screen shot 015

@iliajie
Copy link
Collaborator

iliajie commented Jan 28, 2016

Check for global Webmin settings and Webmin Language and Theme module.

@davenir
Copy link

davenir commented Jan 28, 2016

Yes they are both set - no change

screen shot 017

@iliajie
Copy link
Collaborator

iliajie commented Jan 28, 2016

Checked for VM language? If you can't find, the theme has a language linkbin navigation menu. Enable it in options and then you'll be able to get VM language when on VM.

@iliajie
Copy link
Collaborator

iliajie commented Jan 29, 2016

I think the issue should go after you set proper encoding.

I can not reproduce this issue.. all spaces are tabbed.

screenshot from 2016-01-29 22-01-48

I will update codeMirror with the new release and fix some issues on the black theme for BIND module. If issue persists after 17.60, please let me know, attaching the video-screencast.

Thanks for reporting!

@iliajie iliajie closed this as completed Jan 29, 2016
@davenir
Copy link

davenir commented Feb 1, 2016

Thanks. Still no change for me but I'll see if future updates make a difference.

@iliajie
Copy link
Collaborator

iliajie commented Feb 1, 2016

Post a screen shot for the file please? I think your file itself is not properly formatted, maybe?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants