Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File Manager: Existing bookmarks are not shown #389

Closed
chrispolley opened this issue Feb 15, 2016 · 11 comments
Closed

File Manager: Existing bookmarks are not shown #389

chrispolley opened this issue Feb 15, 2016 · 11 comments
Labels

Comments

@chrispolley
Copy link

Bookmark dropdown says "No bookmarks yet" when I have 5 bookmarks saved. Possibly related to Real-Gecko/Filemin#91 ?

@iliajie
Copy link
Collaborator

iliajie commented Feb 15, 2016

It only happens 'first time' - add at least one bookmark, then reload the page. Now when you add new bookmark, it will be added properly.

I know about this bug. It will be fixed in the future releases.

Thanks for reporting.

@chrispolley
Copy link
Author

No, this has persisted for a while. (several months). There were some extra LFs at the end of the config, which I deleted, but no change was observed. But if you have already fixed, go ahead and close this report; I will check back.

@iliajie
Copy link
Collaborator

iliajie commented Feb 15, 2016

I have a feeling that it's not fixed.

Please install 17.70 and try again?

@iliajie
Copy link
Collaborator

iliajie commented Feb 17, 2016

There should be a directory under your home - ~/.filemin

And you should have a file called .bookmarks.

You must make sure that permissions are correct for the folder. (it should be done automatically).

What linux distros are you on, guys?

@iliajie iliajie changed the title Filemin bookmarks Filemin bookmarks are not shown Feb 17, 2016
@iliajie iliajie changed the title Filemin bookmarks are not shown Existing Filemin bookmarks are not shown Feb 17, 2016
@iliajie iliajie changed the title Existing Filemin bookmarks are not shown File Manager: Existing bookmarks are not shown Feb 17, 2016
@iliajie iliajie added the bug label Feb 17, 2016
@iliajie
Copy link
Collaborator

iliajie commented Feb 17, 2016

Alright. However, I might be fixing it in the future.

Thanks for reporting.

@chrispolley
Copy link
Author

It works in filemin 1.1

But I think previously it was because I am logged in to webmin as "admin"
but it acts as if the user is "root" since the bookmarks are in
/root/.filemin/.bookmarks. Perhaps it was that it wasn't picking up the
correct userid when retrieving bookmarks, although the module config
correctly retrieved them from the ~root folder.

On Wed, Feb 17, 2016 at 4:53 AM, Ilia Rostovtsev notifications@github.com
wrote:

There should be a directory under your home - ~/.filemin

And you should have a file called .bookmarks.

You must make sure that permissions are correct for the folder. (it should
be done automatically).

What linux distros are you at, guys?


Reply to this email directly or view it on GitHub
#389 (comment)
.

@iliajie
Copy link
Collaborator

iliajie commented Feb 17, 2016

Understood. Thanks.

@iliajie
Copy link
Collaborator

iliajie commented Apr 4, 2016

Even though it seems to work correctly, Filemin 1.1 doesn't save bookmarks to the user home directory.

Administrator users, those that are in the wheel group (but not root user itself) doesn't seem to be properly recognized by Webmin. I posted an issue, will see what Jamie thinks about it.

I'll try to enhance bookmarks functionality and detach it from settings page by 17.80 or 17.90 max.

@iliajie
Copy link
Collaborator

iliajie commented Apr 5, 2016

Hi, chrispolley!

Authentic Theme 17.80 will have new mechanism for working with bookmarks. Options will not be needed anymore. You will just need to click on the little remove button near the bookmark to remove it and adding will be the same intuitive way.

Your issue with wheel users will be also fixed. You will need Filemin that is distributed with Webmin.

Thanks for reporting! ;)

@iliajie iliajie closed this as completed Apr 5, 2016
@iliajie
Copy link
Collaborator

iliajie commented Apr 5, 2016

This is how it's going to work in 17.80+

http://rostovtsev.ru/pub/src/authentic/17.80b/file-manager-new-bookmarks.webm

@iliajie
Copy link
Collaborator

iliajie commented Apr 8, 2016

Please upgrade 17.80 is out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants