Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme: Dashboard scrolling issue (Safari iOS 9) #422

Closed
izeen opened this issue Mar 11, 2016 · 32 comments
Closed

Theme: Dashboard scrolling issue (Safari iOS 9) #422

izeen opened this issue Mar 11, 2016 · 32 comments

Comments

@izeen
Copy link

izeen commented Mar 11, 2016

Hi!

This issue has been there for aslong as i have used Autentic-Theme for Webmin i belive,

If you go to the webmin dashboard on a mobile device, specifically iPhone(iOS 9) safari and scroll down a bit you automatically get pulled back up to the top of the site, a little annoying. Any fix i can do to solve this?

@iliajie
Copy link
Collaborator

iliajie commented Mar 11, 2016

To be honest, I have no idea why this is happening (only on iOS) and most importantly I can't really work it out as I don't use iPhone.

I bet it works fine on mobile Chrome? Is there a way you could debug it and provide a fix?

#394

@iliajie iliajie changed the title Scrolling issue safari iOS 9 webmin dashboard Theme: Dashboard scrolling issue (Safari iOS 9) Mar 11, 2016
@izeen
Copy link
Author

izeen commented Mar 11, 2016

I tried to download Chrome for iOS but its the same there, when you scroll down on the Webmin dashboard it hops back up again when you reach the bottom of the Dashboard.

@SteffanCline
Copy link

If you have a Mac you can install XCode which has an iOS Simulator built in and it has Safari. It's what I use to preview web sites in the various iOS display sizes.

@iliajie
Copy link
Collaborator

iliajie commented Mar 18, 2016

Alright, sounds like a deal. It doesn't work for you on the real phone or on simulator? Or it doesn't work on both?

@SteffanCline
Copy link

I haven't even checked. I am just letting you know it exists since you said you don't use iPhone.

@iliajie
Copy link
Collaborator

iliajie commented Mar 18, 2016

Alright. I'll check and try to fix by the next release.

@yd021976
Copy link

Hi, the slow scrolling problem appears on safari on Imac too. I tried with google chrome on the Imac and there is no slow scrolling problem.

I think this bug affect only safari (haven't tried firefox).

@yd021976
Copy link

hi, in addition there is no slow scrolling problem on safari with ios9.1 with an iphone 6.
Still get the problem with my imac (core i7 3,4 ghz) even with all extensions uni stalled and cleared caches.
So i dont know how inspect the slow scrolling problem with developper tools, so i cant help you more with this deal.

@iliajie
Copy link
Collaborator

iliajie commented Apr 12, 2016

What kind of problem exactly exists on your iMac? Scrolling problem? I have MacBook and iMac so I could reproduce the problem.

Please describe it how and when it happens.

@yd021976
Copy link

Hi, yes the problem is very slow scrolling issue.
To reproduce, in webmin select any menu item that shows a page that need to scroll (for exemple "startup and shutdown actions" or "theme options").
Then when i want to scroll, the page is very slow to scroll.

With google chrome, there is no slow scrolling problem.

Thank you.

@yd021976
Copy link

Hi, did you reproduced the problem or do you need more explanations ?

Thank you

@iliajie
Copy link
Collaborator

iliajie commented Apr 16, 2016

This is what I'm doing right now. I got my MacBook Air and 2267 records of installed packages listed in Software Packages Updates.

I don't know what you mean by slow though. It's scrolling - not smooth and happily but works.

Could you please make video with your phone so I understood what you mean?

@yd021976
Copy link

made two videos (safari and chrome) but can't send them with github. Do you have private email ?

@iliajie
Copy link
Collaborator

iliajie commented Apr 16, 2016

You can upload it to Google drive and share it. You can find my email in the theme's files.

@yd021976
Copy link

@iliajie
Copy link
Collaborator

iliajie commented Apr 16, 2016

Alright, thanks! Understood. That is the reason I only use Chrome for development.

My friend, I don't see how this related to the theme? There are thousand or questions on Google asking Why Safari scrolling is slow.

It doesn't happen in default theme as it doesn't have (~0.5mb package.min.css) attached to the head of a page. If you in the Safari console remove it, then things start to work much much faster.

I can't tell you how frustrated I am having lagging Firefox nowadays, while having high-end hardware on my desktop PC. I did so many tweaks and still no luck. Again, Chromium/Chrome works perfectly. Probably Mozilla, Apple and Microsoft must learn few things from Google.

I see the slow page rendering tied to a lot of dependencies. 0.5mb for CSS + ~1.4mb for JS. That slows things down BUT hey, when you have (like you do) very powerful hardware and browser can't allocate more resource to make it work smoothely? Don't know.. I'll be looking but at the moment I have no other thoughts yet..

I was hoping to use iframe-seamless option but it's not supported.

Any ideas anyone?

@iliajie
Copy link
Collaborator

iliajie commented Apr 16, 2016

However I found that icheck on large pages crashes Firefox and when removed all seems fine.. It's a good discovery. I'll try figuring out why and if it's the scripts problem.

@yd021976
Copy link

cool ! hope it will fix the problem !

@iliajie
Copy link
Collaborator

iliajie commented Apr 16, 2016

No, I don't think it will. You can go now to theme settings and set to No -> Enable customized checkboxes and radio buttons.

Does it change anything for you?

@yd021976
Copy link

tried changing settings, but with no luck => still get very slow scrolling

@iliajie
Copy link
Collaborator

iliajie commented Apr 16, 2016

Did you notice checkboxes must change as you disabled this option. I actually found some problems with icheck.

@iliajie
Copy link
Collaborator

iliajie commented Apr 16, 2016

But it doesn't affect anything if it's still slow when it disabled.

@yd021976
Copy link

yes checkboxes changed after tweaking theme. But no change about scrolling pb

@yd021976
Copy link

maybe it's a firefox/safari/microsoft webbrowser related pb... but very strange that only google chrome works fine !

@yd021976
Copy link

...and i don't want google chrome on my machine :-)

@iliajie
Copy link
Collaborator

iliajie commented Apr 16, 2016

Well, if you're going to use Safari - you're not gonna get more privacy/security, I believe. Using proprietary OS makes things even worse.

I would use Linux + Chromium to get privacy, or Firefox if it works fast on your machine.

Install Chromium - it's open source unlike Safari. Besides you can run it as another user if you are afraid for your files being accessed by malicious browser. ;)

@yd021976
Copy link

thanks, but it's not only privacy/security concerns. But agree that chrome rocks with performance !

@iliajie
Copy link
Collaborator

iliajie commented Apr 16, 2016

I would love to know your reasons on why not using it?

Actually, I can't think of where Chrome doesn't rock!? :D

@yd021976
Copy link

You're right : I'm going to use google chrome as it is more powerfull :-)

@iliajie
Copy link
Collaborator

iliajie commented Apr 17, 2016

Ok,

Because of that request, I took a close look to that part of the code and improved it - it will be must much faster as there were couple unneeded loops.

Now Firefox doesn't crash on long tables (like 2000+ rows) and loads decently fast(er).

I don't think it will solve slow scrolling issue but it will definitely be more productive on 17.85+.

@iliajie
Copy link
Collaborator

iliajie commented Apr 17, 2016

By the way, now I understood why some people could not click on the checkboxes (using left click). I could reproduce it with 2000+ rows using old code.

@iliajie
Copy link
Collaborator

iliajie commented Apr 22, 2016

Alright, I have done some code change and lightened the theme a lot.

I can't promise you that it will solve all of the scrolling issues in Safari, as I simply it can't be done on the theme side, I believe.

However, there will be no more slow JavaScript checkboxes/radios, moreover each window (frame) will only load needed dependencies. Default palettes are going to be removed from the package and shipped separately, again, to make things lighter and faster.

Yes, and Firefox will not be crashing on large pages as well.

There will be more change/improvement.

Expect it in version 18.00 in around two weeks as there is enormous amount of work to be done.

Regards,
Ilia

@iliajie iliajie closed this as completed Apr 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants