Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme: Module's chooser filtering not working #552

Closed
acosonic opened this issue Sep 27, 2016 · 5 comments
Closed

Theme: Module's chooser filtering not working #552

acosonic opened this issue Sep 27, 2016 · 5 comments
Labels

Comments

@acosonic
Copy link

Overflow should be visible, because people might not know what they want to install they might just want to browse modules and install them based on description.

Filter is not working.

2016-09-27 09_07_53-

@iliajie
Copy link
Collaborator

iliajie commented Sep 27, 2016

Yes it should and it was fixed in version 18.10.

Please upgrade your Webmin version which will ship the new version of the theme. (latest 18.10 at the moment).

@iliajie iliajie closed this as completed Sep 27, 2016
@iliajie
Copy link
Collaborator

iliajie commented Sep 27, 2016

and filter will be fixed on the next release.

@iliajie iliajie reopened this Sep 27, 2016
@iliajie iliajie changed the title Webmin modules chooser overflow hidden and filter not working Theme: Modules chooser filter not working Sep 27, 2016
@iliajie iliajie added the bug label Sep 27, 2016
@iliajie iliajie changed the title Theme: Modules chooser filter not working Theme: Module's chooser filtering not working Sep 27, 2016
@iliajie
Copy link
Collaborator

iliajie commented Oct 29, 2016

After 18.20 release in few days, I will start working on enhancements. One of them will dropping old popup windows and replacing it with nice modals.

Meanwhile, I will not put effort in fixing it. If I succeeded in it will be resolved by it self if it will not be possible, then I will find the way to fix it.

@acosonic
Copy link
Author

Ok, if you need my help with something I can work on it.
On Oct 29, 2016 4:59 PM, "Ilia Rostovtsev" notifications@github.com wrote:

After 18.20 release in few days, I will start working on enhancements. One
of them will dropping old popup windows and replacing it with nice modals.

Meanwhile, I will not put effort in fixing it. If I succeeded in it will
be resolved by it self if it will not be possible, then I will find the way
to fix it.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#552 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA0nP-ADTxVSx0K9CyrZjx2sHI9Fs2cWks5q419ZgaJpZM4KHVAa
.

@iliajie
Copy link
Collaborator

iliajie commented Dec 3, 2016

Hi,

I have finally made through replacing old window.open() with nice and sleek modals:

Example

It will also fix your issue. Expect it done in 18.30. ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants