Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File Manager: iPad modals do not work #571

Closed
Martin-By opened this issue Nov 2, 2016 · 6 comments
Closed

File Manager: iPad modals do not work #571

Martin-By opened this issue Nov 2, 2016 · 6 comments

Comments

@Martin-By
Copy link

Martin-By commented Nov 2, 2016

my setup theme (18.20) and Webmin (1.820)

Still follwing as 18.10:

-navigating to file
-marking file
-choosing action (here chmod)

pop ups a greyed window without any action (same safari and firefox)

@iliajie
Copy link
Collaborator

iliajie commented Nov 2, 2016

I will take a look. However I don't have an iPad to test it.

First look tells me there are a lot of issues like that already.

Could you please go to Bootstrap website and check how modals are working there?

@iliajie iliajie changed the title Filemanager 18.20: Ipad still not working File Manager: iPad modals do work Nov 2, 2016
@iliajie iliajie changed the title File Manager: iPad modals do work File Manager: iPad modals do not work Nov 2, 2016
@Martin-By
Copy link
Author

Ok, "launch demo modals" works:

  • can open window
  • can open window via button
  • can close the window with button

@iliajie
Copy link
Collaborator

iliajie commented Nov 2, 2016

..your main complain that you can't see modal at all on the iPad and that's it?

@iliajie
Copy link
Collaborator

iliajie commented Nov 28, 2016

Hi,

I could really reproduce this bug on iPad Pro.

I have made pull-request to Webmin repo.

@iliajie iliajie closed this as completed Nov 28, 2016
@iliajie
Copy link
Collaborator

iliajie commented Nov 28, 2016

It will be fixed on the theme side in 18.30. Webmin fix was incorrect. We keep modals on the inside as it contains form elements. Otherwise it would require a lot of redo.

@iliajie
Copy link
Collaborator

iliajie commented Nov 28, 2016

..and other recommendation that will make it work right now -

Just go to Safari on iPad and Request desktop version of the website under share icon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants