Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linux Firewall displays poorly with multiple IPs #687

Closed
adiastra opened this issue Mar 22, 2017 · 19 comments
Closed

Linux Firewall displays poorly with multiple IPs #687

adiastra opened this issue Mar 22, 2017 · 19 comments

Comments

@adiastra
Copy link

adiastra commented Mar 22, 2017

When adding a long list of IPs to a firewall rule, you can not add spaces so the rules summary screen does not break the line at the comma. This pushes the display off to the right too far. Also when ENTERING this information the provided "text box" is not sufficient and should be a "text area" instead
see http://i.imgur.com/2c9Rpip.jpg for example

To recreate this just add a large list of comma separated IPs ( 10 or more without spaces[example of formatting 67.174.104.101,96.244.12.80,98.231.163.151,192.88.134.0/23,185.93.228.0/22,66.248.200.0/22,103.21.244.0/22,103.22.200.0/22,103.31.4.0/22,104.16.0.0/12,108.162.192.0/18,131.0.72.0/22,141.101.64.0/18,162.158.0.0/15,172.64.0.0/13,173.245.48.0/20,188.114.96.0/20,190.93.240.0/20,197.234.240.0/22,198.41.128.0/17,199.27.128.0/21])
to "Source address or network" in any rule then save it and look at the rules summary screen.

Spaces are not allowed in iptables so a different solution would be to allow for multiple lines to be input and then create the proper formatted input (see above) before adding it to the rule.

@iliajie
Copy link
Collaborator

iliajie commented Mar 22, 2017

May be word-wrap: break-word on the line would make things look better? Could you try adding using browser's DevTools?

@adiastra
Copy link
Author

adiastra commented Mar 22, 2017

where would you like me to enter word-wrap: break-word ?
im not a css wiz. in the label tag?

@iliajie
Copy link
Collaborator

iliajie commented Mar 22, 2017

On the parent container, like td I guess or whichever tag is affecting it. Just right click on the text and click inspect. At the top, where element style is, add the line above and see if it works.

And if it's hard for you, please don't bother. I'll figure this out.

@adiastra
Copy link
Author

did this
http://i.imgur.com/DsvfXz5.jpg
no effect

@adiastra
Copy link
Author

tried this too
style="width: 100%; word-wrap: break-word; table-layout: fixed;" no dice

@iliajie
Copy link
Collaborator

iliajie commented Mar 22, 2017

This will fix it for you. 😉

Thanks for reporting.

@adiastra
Copy link
Author

How can I apply the hotfix? or will it be in the next release?

@iliajie
Copy link
Collaborator

iliajie commented Mar 23, 2017

It will be. Or you can easily do it using console.

https://github.com/qooob/authentic-theme#how-to-update-authentic-theme-manually

@adiastra
Copy link
Author

Thanks that's perfect!

@iliajie
Copy link
Collaborator

iliajie commented Mar 23, 2017

😉 good to know.

iliajie pushed a commit that referenced this issue May 5, 2017
@nsaneman
Copy link

nsaneman commented Nov 16, 2017

@qooob Hopefully you've got notifications on. This issue is back again.

Firewall

I'm using 19.02. If I downgrade to 19.01 it looks a little better, although it adds a scrollbar to the bottom.

@iliajie
Copy link
Collaborator

iliajie commented Nov 16, 2017

What would be expected output?

@iliajie
Copy link
Collaborator

iliajie commented Nov 16, 2017

... to wrap?

@nsaneman
Copy link

nsaneman commented Nov 16, 2017

Preferably truncate long text with ellipsis so that move/add are always displayed to the right without scrolling. I know that some people might want to see all of the IP addresses though, but I don't think wrapping would work well.

If you don't agree with using ellipsis then just make it use the scrollbar like in 19.01. It'll look a little poor, but it's functional.

Maybe the checkboxes need to be adjusted too? They're not perfectly positioned.

@iliajie
Copy link
Collaborator

iliajie commented Nov 16, 2017

I'll look for better solution. Yes, checkboxes shouldn't stick to the left.

@iliajie
Copy link
Collaborator

iliajie commented Dec 2, 2017

I do believe that wraping looks great here.

@iliajie
Copy link
Collaborator

iliajie commented Dec 2, 2017

Example:

screenshot from 2017-12-02 18-17-01

@adiastra
Copy link
Author

adiastra commented Dec 2, 2017 via email

@nsaneman
Copy link

nsaneman commented Dec 7, 2017

That actually looks better than I thought it would. Thanks for addressing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants