Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme: File chooser click operations #693

Closed
Sopor opened this issue Mar 24, 2017 · 7 comments
Closed

Theme: File chooser click operations #693

Sopor opened this issue Mar 24, 2017 · 7 comments

Comments

@Sopor
Copy link
Contributor

Sopor commented Mar 24, 2017

When i want to install the CSF module for Webmin i do that by pressing the button after From uploaded file. A new window will open so i can browse to the file but if i click on a folder name it will close the window and the same thing happens if i click on the yellow folder to the left of the folder name. So how do i browse into the folder? Of course, i double click on the yellow icon!
Here is the big difference between your theme and the Gray theme. If i single click on the yellow icon nothing will happens in the Gray theme but in your theme it will select it the same way single click do on the folder name. This will make the user very confused (at least i got confused).

I'm using Firefox and 18.40 theme. Tested in both Windows and Ubuntu.

@iliajie
Copy link
Collaborator

iliajie commented Mar 25, 2017

Well, maybe. But it's like browsing thing and all File Managers want you to do double-click by default to descend into folder, right?

There are no much options, that I could use. I know about the way it worked before, I didn't find it anyway better or less confusing.

@Sopor
Copy link
Contributor Author

Sopor commented Mar 25, 2017

If a single click won't work when i press on the yellow folder icon then i will try to double click on it, but if i can single click on it then i believe it work the same way as when i press on the folder name. It took me some time before i figure it out how to do it. I even started to write a report about it but when i was playing around with it i manage to find out how it worked but it was after i have changed to the Gray theme. When i found out that nothing happens when i single click on the yellow icon, i then tried double click on it and it worked. I then change the theme back to Authentic theme and when i tried to double click it worked here too. This is no regular file manager, at least not the one in the Gray theme so you can never anticipate how it should work.

@iliajie
Copy link
Collaborator

iliajie commented Mar 25, 2017

OK,

Any direct suggestions of how it should be?

@Sopor
Copy link
Contributor Author

Sopor commented Mar 25, 2017

I vote for the same way as the Gray theme work.
Single click on the name will select it and close the "file browser".
Double click on the yellow folder icon opens the folder and let me continue browse.
Single click on the yellow folder icon do nothing. To select you need to click the name and not the folder icon.

@iliajie
Copy link
Collaborator

iliajie commented Mar 26, 2017

Hmm.
It's not the way the default works, in my opinion.

What if you need to select the folder?

@iliajie iliajie changed the title Selecting and open folders are different between themes... Theme: File chooser click operations Mar 26, 2017
@Sopor
Copy link
Contributor Author

Sopor commented Mar 26, 2017

If you need to select the folder you click on the name instead of the icon.
When i tested Gray theme it worked like that, but i can test it again.

@iliajie
Copy link
Collaborator

iliajie commented Mar 26, 2017

Ok,

I will rework it very soon.

iliajie pushed a commit that referenced this issue May 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants