Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme: Automatic update #695

Closed
Sopor opened this issue Mar 26, 2017 · 3 comments
Closed

Theme: Automatic update #695

Sopor opened this issue Mar 26, 2017 · 3 comments

Comments

@Sopor
Copy link
Contributor

Sopor commented Mar 26, 2017

I was running Authentic theme 18.30 and i know you released a new version so i activated the 'Check for Authentic Theme updates' and i could see there was a new version available so i pressed the Update button and it started to happen things but after a few seconds i was back to the Dashboard and it was still version 18.30. I then tried again, same thing and it was still version 18.30. I then tried a third time and when it was finished i got the announce window that 18.40 was installed. Why do i need to do it three times? I noticed Github was slow so maybe you need to wait longer for it to download, install and then restart Webmin (or you don't restart Webmin after an update?)?
All four computers are now updated to 18.40 so i can't test it so easy. I can of course download 18.30 and manually install it if you want me to help you find the reason to this issue.

@iliajie
Copy link
Collaborator

iliajie commented Mar 26, 2017

I think you will not be able to reproduce it. It happens sometimes, as connection to GitHub is dropped.

It's not the theme issue as far as I'm aware. I could never reproduce it twice.

What happens is when you put a link to input field and hit install, it's just getting dropped/skipped. In ordinary install there could be a message.

@iliajie iliajie closed this as completed Mar 26, 2017
@Sopor
Copy link
Contributor Author

Sopor commented Mar 26, 2017

And you are sure about this? It is not because Webmin is running on a Raspberry Pi 2? It will take some time to download and extract on an RPi2.
I updated your theme on my i5 (SSD) by doing a 'git pull' but next time i will use the Update button to see if it happens on that computer too.

@iliajie
Copy link
Collaborator

iliajie commented Mar 26, 2017

It happened with me many times. Anytime later it just worked fine.

It's hard to figure out why it was happening..

I will try to add more delay when the file is inserted into the field, it's the only thing I can think of!

@iliajie iliajie reopened this Mar 26, 2017
@iliajie iliajie changed the title Update issue! - I was forced to press the update button three times... Theme: Automatic update Mar 26, 2017
iliajie pushed a commit that referenced this issue May 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants