-
-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
'Keep slider always visible' on/off i don't even have to press the Save button #697
Comments
Yes, it's only active until the first full page reload. Right? |
Maybe it is, but it shouldn't be active before i press the Save button. It was the same behavior for the notification tab but you changed that so now i have to press Save for it to get away. |
Well, I actually did it on purpose. I find this user friendly to make things displayed upon toggling options, when possible. |
Ok, I have made few tweaks to make sure that the user will be aware that the the settings should be saved. Other than than, reverting to previous settings, unsaved could be possible but would take much more work and bring extra complexity. I realize that it would be slightly better but I don't think it's gonna worth it especially after this patch. |
When changing 'Keep slider always visible' on/off i don't even have to press the Save button. If you have a Save button it should also have to be used. If i want to undo my changes, how do i do then?
I noticed that if i don't press save and leave the page and when i get back it will still show the slider but 'Keep slider always visible' is still set to 'off'.
I believe it was the same behavior on the notification tab in #673.
v18.40
The text was updated successfully, but these errors were encountered: