Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File Manager: Escaping HTML and other issues #716

Closed
iliajie opened this issue Apr 13, 2017 · 1 comment
Closed

File Manager: Escaping HTML and other issues #716

iliajie opened this issue Apr 13, 2017 · 1 comment

Comments

@iliajie
Copy link
Collaborator

iliajie commented Apr 13, 2017

There were found some issues:

  1. Not displaying whitespaces properly in file names
  2. Not opening directories correctly when quotes are used
  3. Not sanitizing tricky file names, like str_<p onmouseover="alert(1)">.txt(1)(1)
@iliajie iliajie closed this as completed Apr 14, 2017
@iliajie
Copy link
Collaborator Author

iliajie commented Apr 14, 2017

Few more things to fix.

  1. Directory having % not working correctly;
  2. New tab for tricky directory name lacks of proper escaping;
  3. Navigation breadcrumb quick access acts fancy on directories having single or double quotes, i.e. shows content of the current directory instead of a parent;
  4. Directory loader is not showing when clicking on it;
  5. Manual path input should be decoding the string.

@iliajie iliajie reopened this Apr 14, 2017
@iliajie iliajie added this to the 90% milestone Apr 15, 2017
@iliajie iliajie closed this as completed Apr 16, 2017
iliajie pushed a commit that referenced this issue Apr 17, 2017
@iliajie iliajie removed this from the 90% milestone Apr 18, 2017
iliajie pushed a commit that referenced this issue Apr 18, 2017
iliajie pushed a commit that referenced this issue May 5, 2017
iliajie pushed a commit that referenced this issue May 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant