Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating from 18.47 to 18.49 will show 18.48 as current installed version #780

Closed
Sopor opened this issue May 18, 2017 · 10 comments
Closed

Comments

@Sopor
Copy link
Contributor

Sopor commented May 18, 2017

I was running version 18.47-git-201705032200 and i used the force update and after the update i could see at the bottom of the screen 18.48 but the Dashboard will now show 18.49 after the update.

screenshot
Is this really correct?

@iliajie
Copy link
Collaborator

iliajie commented May 18, 2017

It's not. I will try to reproduce it. Looks like cache issue.

@iliajie
Copy link
Collaborator

iliajie commented May 18, 2017

Hi,

I tried two times and I couldn't reproduce this issue. It's practically impossible as the data is derived from the updated version of the theme by reading a file.

In File Manager, you could go to /usr/share/webmin/authentic-theme (as far as I remember you're on Ubuntu) and try to search through files' contents for the match 18.48. In case it's found then, it's mystery cache issue.

Other than that, try hitting force-update one more time.

Script works straight forward way, in case rm and mv commands are not executed as expected, I can not do much more here.

@iliajie iliajie closed this as completed May 18, 2017
@Sopor
Copy link
Contributor Author

Sopor commented May 18, 2017

I have 4 Webmin and i have updated three of them so far and they all showed 18.48. The fourth i was waiting for your fix to verify it was working.

@iliajie
Copy link
Collaborator

iliajie commented May 18, 2017

I'm sorry, but there will be no fix this time, as I don't know what to fix. Besides, it's not critical at all and doesn't worth bothering. Please try what I asked in the message above.

However, I will keep it in mind for the future.

@Sopor
Copy link
Contributor Author

Sopor commented May 18, 2017

But what should it show here? The updated version or the previous version? I'm at 18.47-git-201705041727 but the VERSION.txt will show 18.48 and version will show 18.47-git-201705041727.

@iliajie
Copy link
Collaborator

iliajie commented May 18, 2017

First of all, it's not correct that you have different versions right now on your system. It should be either 18.47* or 18.48* for both files.

At second, it's not important what versions are there if you do force update.

Can you please run second time force upgrade, what do you get?

In the end, no worries about this. When things come to server side, it's pretty straight forward. One more advice, if it still doesn't work (which I doubt), try using console script and check what it says and what the outcome will be. 😉

@Sopor
Copy link
Contributor Author

Sopor commented May 18, 2017

This is not the first time i have seen this but i didn't know if it should show the installed version or the previous version. Sometimes it is a bit hard to understand how you coders are thinking 😄

@iliajie
Copy link
Collaborator

iliajie commented May 18, 2017

😁 It's written Currently installed version is xx.xx - it sounds very concrete to me. If you want to rephrase it some better way, please let me know. I'm open-minded person.

@Sopor
Copy link
Contributor Author

Sopor commented May 19, 2017

Now i did a force update to 18.49-1 but the message was showing 18.49

picpick-2017 05 20-01 23 43

@iliajie
Copy link
Collaborator

iliajie commented May 20, 2017

This is a bug, will fix it in 18.49-2. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants