Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRLF in Many Files #40

Open
wirelessben opened this issue Feb 16, 2022 · 3 comments
Open

CRLF in Many Files #40

wirelessben opened this issue Feb 16, 2022 · 3 comments

Comments

@wirelessben
Copy link

I'm trying to build a matching binary for reload4j-1.2.19.jar, but there are CRLFs in the following files:
11568 02-08-2022 08:07 META-INF/LICENSE
164 02-08-2022 08:07 META-INF/NOTICE
1462 02-08-2022 08:07 org/apache/log4j/lf5/config/defaultconfig.properties
7265 02-08-2022 08:07 org/apache/log4j/xml/log4j.dtd
16175 02-08-2022 08:07 META-INF/maven/ch.qos.reload4j/reload4j/pom.xml
62 02-08-2022 08:07 META-INF/maven/ch.qos.reload4j/reload4j/pom.properties

Building on a Mac with Java 8, I just get regular LFs, thus causing the diffs. I did switch to branch 982b720 before building with Maven 3.8.4.
reload4j git:(982b7205) ✗ mvn --version Apache Maven 3.8.4 (9b656c72d54e5bacbed989b64718c159fe39b537) Maven home: /usr/local/Cellar/maven/3.8.4/libexec Java version: 1.8.0_301, vendor: Oracle Corporation, runtime: /Library/Java/JavaVirtualMachines/jdk1.8.0_301.jdk/Contents/Home/jre Default locale: en_US, platform encoding: UTF-8 OS name: "mac os x", version: "10.16", arch: "x86_64", family: "mac"

@ceki
Copy link
Member

ceki commented Feb 17, 2022

Thank you for the heads up. I'll have a look at these CRLF issues.

@ceki ceki reopened this Feb 17, 2022
@ceki
Copy link
Member

ceki commented Feb 17, 2022

When built in different environments, I see trailing white space issue in some files. More importantly, I see differences in some class files as well.

@wirelessben
Copy link
Author

Yes, I also saw the differences in these two class files:

org/apache/log4j/jdbc/JDBCAppender.class
org/apache/log4j/xml/DOMConfigurator$2.class

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants