Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FomatConfig.Map methods shouldn't need to check nil #172

Open
b5 opened this issue Feb 4, 2019 · 0 comments
Open

FomatConfig.Map methods shouldn't need to check nil #172

b5 opened this issue Feb 4, 2019 · 0 comments
Labels
chore Changes to the build process or auxiliary tools and libraries such as documentation generation ready

Comments

@b5
Copy link
Member

b5 commented Feb 4, 2019

we don't do this nil-check-early-return thing anywhere else in our codebase. Let's get rid of it.
@b5 b5 added the chore Changes to the build process or auxiliary tools and libraries such as documentation generation label Feb 4, 2019
@b5 b5 mentioned this issue Feb 4, 2019
Merged
@b5 b5 added the ready label Feb 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore Changes to the build process or auxiliary tools and libraries such as documentation generation ready
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@b5