You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As mentioned in the issue, +Inf is being written to a cell of CSV
the CSV valueReader is totally fine with +Inf, but the conversion to JSON for validation is not happy with a number of type "+Inf"
Two ways this could be improved:
The reporting error could specify the address within the row so we know the exact cell. In the reported issue our user was concerned it might have been emojis (which were also present in that row). Specifying the row that's causing the problem would help rule this out earlier
Qri needs to be a little smarter about these pseudo-numeric values like NaN and +Inf. They aren't numbers, and when we encounter them, things like format conversion gets dicy.
Steps to close this
Write a set of good-case interop tests that push a common value of each type through a relay of all supported formats by wrapping multiple writers CSV -> XLSX -> JSON -> CBOR -> CSV. These should pass with an equality test matching input & output. This'll help confirm we're not doing silly things during format conversion
We need to formalize how we handle +Inf and NaN. Once we do, write a test pushing +Inf and NaN around. Let's use this issue to work that out
One Day
Produce a warning to lets
The text was updated successfully, but these errors were encountered:
qri-io/desktop#478 uncovered this with the following error message when running
qri save
:What's going on here:
+Inf
is being written to a cell of CSV+Inf
, but the conversion to JSON for validation is not happy with a number of type"+Inf"
Two ways this could be improved:
NaN
and+Inf
. They aren't numbers, and when we encounter them, things like format conversion gets dicy.Steps to close this
CSV -> XLSX -> JSON -> CBOR -> CSV
. These should pass with an equality test matching input & output. This'll help confirm we're not doing silly things during format conversion+Inf
andNaN
. Once we do, write a test pushing+Inf
andNaN
around. Let's use this issue to work that outOne Day
The text was updated successfully, but these errors were encountered: