fix(workingDatasetReducer): if 422 error, don't clear dataset state

if the error was 422, the dataset still exists, don't clear state, we are about to request the dataset info again.

app/components/DatasetSidebar.tsx

@@ -12,7 +12,7 @@ import ComponentList from './ComponentList'
 import classNames from 'classnames'
 import Spinner from './chrome/Spinner'
 
-import { WorkingDataset, ComponentType, Selections, CommitDetails } from '../models/store'
+import { WorkingDataset, ComponentType, Selections } from '../models/store'
 
 interface HistoryListItemProps {
   path: string
@@ -45,7 +45,6 @@ export interface DatasetSidebarProps {
   selections: Selections
   workingDataset: WorkingDataset
   hideCommitNudge: boolean
-  commitDetails: CommitDetails
   setActiveTab: (activeTab: string) => Action
   setSelectedListItem: (type: ComponentType, activeTab: string) => Action
   fetchWorkingHistory: (page?: number, pageSize?: number) => ApiActionThunk
@@ -62,13 +61,11 @@ const DatasetSidebar: React.FunctionComponent<DatasetSidebarProps> = (props) =>
     setSelectedListItem,
     fetchWorkingHistory,
     discardChanges,
-    setHideCommitNudge,
-    commitDetails
+    setHideCommitNudge
   } = props
 
   const { path, fsiPath, history, status, components } = workingDataset
-  const { isLoading: commitIsLoading, components: commitComponents } = commitDetails
-  const { body: commitBody } = commitComponents
+
   const {
     activeTab,
     component: selectedComponent,
@@ -84,9 +81,6 @@ const DatasetSidebar: React.FunctionComponent<DatasetSidebarProps> = (props) =>
   const historyLoaded = !history.pageInfo.isFetching
   const statusLoaded = !!status
   const bodyLoaded = !body.pageInfo.isFetching
-  const commitLoaded = !commitIsLoading
-  const commitBodyLoaded = !commitBody.pageInfo.isFetching
-
   const noHistory = history.value.length === 0
 
   const handleHistoryScroll = (e: any) => {
@@ -191,7 +185,7 @@ const DatasetSidebar: React.FunctionComponent<DatasetSidebarProps> = (props) =>
           </div>
         </CSSTransition>
         {
-          !hideCommitNudge && bodyLoaded && commitLoaded && commitBodyLoaded && statusLoaded && historyLoaded && noHistory && datasetSelected && (
+          !hideCommitNudge && bodyLoaded && statusLoaded && historyLoaded && noHistory && datasetSelected && (
             <div className='commit-nudge'>
               <div className='commit-nudge-text'>
                 You&apos;re ready to make your first commit on this dataset! Verify that the body and meta are accurate, enter a commit message below, and click Submit.

app/containers/DatasetSidebarContainer.tsx

@@ -31,7 +31,6 @@ const DatasetSidebarContainer = connect(
     const {
       selections,
       workingDataset,
-      commitDetails,
       ui
     } = state
 
@@ -42,8 +41,7 @@ const DatasetSidebarContainer = connect(
       selections,
       workingDataset,
       setModal,
-      hideCommitNudge,
-      commitDetails
+      hideCommitNudge
     }, ownProps)
   },
   {

app/reducers/workingDataset.ts

@@ -91,6 +91,11 @@ const workingDatasetsReducer: Reducer = (state = initialState, action: AnyAction
         }
       }
     case DATASET_FAIL:
+      // if the error is 422, we are going to rerequest this
+      // dataset using 'fsi=false'
+      if (action.payload.err.code === 422) {
+        return state
+      }
       return {
         ...initialState,
         isLoading: false