Skip to content

Commit

Permalink
fix(Dataset): add Hamburger to dataset actions
Browse files Browse the repository at this point in the history
this adds back the `Copy Cloud Link` and `Unpublish` options
  • Loading branch information
ramfox committed Feb 3, 2020
1 parent 530872b commit c4d0c6a
Show file tree
Hide file tree
Showing 3 changed files with 25 additions and 56 deletions.
43 changes: 0 additions & 43 deletions RELEASE_PROCESS.md

This file was deleted.

35 changes: 22 additions & 13 deletions app/components/Dataset.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import NoDatasetSelected from './NoDatasetSelected'
import { Modal, ModalType } from '../models/modals'
import { defaultSidebarWidth } from '../reducers/ui'
import HeaderColumnButton from './chrome/HeaderColumnButton'
import HeaderColumnButtonDropdown from './chrome/HeaderColumnButtonDropdown'
// import HeaderColumnButtonDropdown from './chrome/HeaderColumnButtonDropdown'
import DatasetSidebar from '../components/DatasetSidebar'
import DetailsBarContainer from '../containers/DetailsBarContainer'
import CommitDetails from './CommitDetails'
Expand All @@ -33,6 +33,7 @@ import {
import NoDatasets from './NoDatasets'
import { defaultPollInterval } from './App'
import { Details } from '../models/details'
import Hamburger from './chrome/Hamburger'

export interface DatasetData {
workingDataset: WorkingDataset
Expand Down Expand Up @@ -92,7 +93,8 @@ class Dataset extends React.Component<DatasetProps> {
'publishUnpublishDataset',
'handleShowStatus',
'handleShowHistory',
'handleReload'
'handleReload',
'handleCopyLink'
].forEach((m) => { this[m] = this[m].bind(this) })
}

Expand Down Expand Up @@ -178,6 +180,10 @@ class Dataset extends React.Component<DatasetProps> {
remote.getCurrentWindow().reload()
}

handleCopyLink () {
clipboard.writeText(`${QRI_CLOUD_URL}/${this.props.data.workingDataset.peername}/${this.props.data.workingDataset.name}`)
}

componentDidUpdate (prevProps: DatasetProps) {
const {
data,
Expand Down Expand Up @@ -359,22 +365,25 @@ class Dataset extends React.Component<DatasetProps> {
let publishButton
if (username === peername && datasetSelected) {
publishButton = published ? (
<HeaderColumnButtonDropdown
<><HeaderColumnButton
id='publishButton'
onClick={() => { shell.openExternal(`${QRI_CLOUD_URL}/${data.workingDataset.peername}/${data.workingDataset.name}`) }}
icon={faCloud}
label='View in Cloud'
items={[
<li key={0} onClick={(e) => {
e.stopPropagation()
clipboard.writeText(`${QRI_CLOUD_URL}/${data.workingDataset.peername}/${data.workingDataset.name}`)
}}>Copy Link</li>,
<li key={1} onClick={(e) => {
e.stopPropagation()
setModal({ type: ModalType.UnpublishDataset })
}}>Unpublish</li>
]}
/>
<Hamburger data={[
{
icon: 'clone',
text: 'Copy Cloud Link',
onClick: this.handleCopyLink
},
{
icon: 'close',
text: 'Unpublish',
onClick: () => setModal({ type: ModalType.UnpublishDataset })
}
]} />
</>
) : (
<span data-tip={
data.workingDataset.history.value.length === 0
Expand Down
3 changes: 3 additions & 0 deletions app/scss/_sidebar-layout.scss
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,9 @@

.main-content-header {
flex: 0;
display: flex;
align-items: center;
padding: 5px 0;

.header-column {
display: inline-flex;
Expand Down

0 comments on commit c4d0c6a

Please sign in to comment.