fix: disable publish button if no history

qri-io · Sep 3, 2019 · f4a673e · f4a673e
1 parent 7790a88
commit f4a673e
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 3 deletions.
diff --git a/app/components/Dataset.tsx b/app/components/Dataset.tsx
@@ -259,7 +259,7 @@ export default class Dataset extends React.Component<DatasetProps> {
       publishButton = published ? (
         <HeaderColumnButtonDropdown
           onClick={() => { shell.openExternal(`${QRI_CLOUD_URL}/${workingDataset.peername}/${workingDataset.name}`) }}
-          icon='faCloud'
+          icon={faCloud}
           label='View in Cloud'
           items={[
             <a key={0} onClick={(e) => { shell.openExternal(`${QRI_CLOUD_URL}/${workingDataset.peername}/${workingDataset.name}`); e.stopPropagation() }}>Copy Link</a>,
@@ -271,6 +271,7 @@ export default class Dataset extends React.Component<DatasetProps> {
           label='Publish'
           icon={faCloudUploadAlt}
           tooltip={'Publish this dataset on the Qri network'}
+          disabled={workingDataset.history.value.length === 0}
           onClick={this.publishUnpublishDataset}
         />
       )

diff --git a/app/components/chrome/HeaderColumnButton.tsx b/app/components/chrome/HeaderColumnButton.tsx
@@ -1,20 +1,22 @@
 import * as React from 'react'
+import classNames from 'classNames'
 import { FontAwesomeIcon } from '@fortawesome/react-fontawesome'
 import { IconDefinition } from '@fortawesome/free-regular-svg-icons'
 
 export interface HeaderColumnButtonProps {
   tooltip?: string
   label?: string
   icon: IconDefinition | React.ReactElement
+  disabled?: boolean
   onClick?: (event: React.MouseEvent) => void
 }
 
 const HeaderColumnButton: React.FunctionComponent<HeaderColumnButtonProps> = (props) => {
-  const { icon, label, tooltip, onClick } = props
+  const { icon, label, tooltip, disabled, onClick } = props
 
   return (
     <div
-      className='header-column'
+      className={classNames('header-column', { disabled })}
       data-tip={tooltip}
       onClick={onClick}
     >

diff --git a/app/scss/_dataset.scss b/app/scss/_dataset.scss
@@ -88,6 +88,14 @@ $header-font-size: .9rem;
     align-items: center;
     position: relative;
 
+    &.disabled {
+      color: #66737b;
+      pointer-events: none;
+      &:hover {
+        background-color: inherit;
+      }
+    }
+
     &.header-column-dropdown, &.current-dataset {
       padding-right: 0;
     }

diff --git a/app/utils/registry.ts b/app/utils/registry.ts
@@ -1,2 +1,6 @@
 
+<<<<<<< HEAD
 export const QRI_CLOUD_URL = 'https://qri.cloud'
+=======
+export const QRI_CLOUD_URL = 'http://qri.cloud'
+>>>>>>> fix: disable publish button if no history