Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collection and Network Styling Improvements #631

Open
5 tasks done
chriswhong opened this issue Oct 2, 2020 · 3 comments
Open
5 tasks done

Collection and Network Styling Improvements #631

chriswhong opened this issue Oct 2, 2020 · 3 comments
Assignees

Comments

@chriswhong
Copy link
Contributor

chriswhong commented Oct 2, 2020

Collection View

  • Prevent horizontal scrolling (flex)
  • Border under list header
  • Clean up padding/margins
  • Hover styling - indicate clickability
  • Handle long dataset references

all closed in #633

Network View

  • Center loading spinner
  • Use DatasetSummmary from qri cloud for consistent list view
  • Revisit header text/size
  • Network preview
    • header text
    • Cleanup unneeded text in sidebar header
    • Minor improvements to Preview pane/components
@chriswhong chriswhong self-assigned this Oct 2, 2020
@chriswhong
Copy link
Contributor Author

In order to use DatasetSummary cards from cloud in desktop, we need the following additional values in VersionInfo

Description and Keywords:
metaDescription
keywords

If we want to show the stats in the top right of the card:
downloadCount
pullCount
issueStats
followStats

@chriswhong chriswhong mentioned this issue Oct 6, 2020
35 tasks
@b5
Copy link
Member

b5 commented Oct 6, 2020

ok, getting all of these delivered is going to take a bunch of doing on the backend. For now I think we should redact these fields from desktop & create an issue to add them back

@dustmop
Copy link
Contributor

dustmop commented Oct 7, 2020

Question about this. We basically defined VersionInfo as "what qri list needs to display its results", with the near future plan that dscache would store exactly a list of VersionInfo. Most of these fields are only relevant to cloud, right? In other words, they don't make any sense for a user's local list of datasets. In that case, it sounds like this is a cloud-specific need, and shouldn't be added to VersionInfo, rather it should be some different type of api call.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants