Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

general error handling #590

Open
Arqu opened this issue Nov 18, 2021 · 1 comment · May be fixed by #665
Open

general error handling #590

Arqu opened this issue Nov 18, 2021 · 1 comment · May be fixed by #665
Labels
enhancement New feature or request

Comments

@Arqu
Copy link
Contributor

Arqu commented Nov 18, 2021

We've sorted out most of our error handling by now with manual catches. However every now and then we find a weird edgecase like a random api call fail that was unexpected and the frontend explodes.

We should have a general error catcher on the api level which if a request fails simply shows a toast/error message and aborts further code execution. This will prevent ugly ui degradation in case something odd happens while users are playing around.
@Arqu Arqu added the enhancement New feature or request label Nov 18, 2021
@chriswhong
Copy link
Contributor

related to #306

@boandriy boandriy linked a pull request Jan 11, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added toast for general errors qri-io/frontend
2 participants
@Arqu @chriswhong