Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[auth] Add a "remember me" checkbox to the login modal #644

Open
chriswhong opened this issue Dec 11, 2021 · 1 comment
Open

[auth] Add a "remember me" checkbox to the login modal #644

chriswhong opened this issue Dec 11, 2021 · 1 comment
Labels

Comments

@chriswhong
Copy link
Contributor

The app will randomly log the user out. Tokens are not refreshing as they should. Investigate and ensure that the user can stay logged in for a reasonable time.

@chriswhong chriswhong added the bug Something isn't working label Dec 11, 2021
@Arqu
Copy link
Contributor

Arqu commented Dec 17, 2021

Hey, I came this from a completely different angle. There's probably a few things at play, I solved the backend technical issue. https://github.com/qri-io/cloud/pull/633

The thing was that the lower level lib for it changed the error formatting and on some update we classified expired access tokens as a failure case. This meant you had to do a call to refresh (any api call would trigger it) in the last 5 minutes (ie the window when frontend triggers a refresh) and before it's expired so it doesn't fail. That's fixed now and it works as long as the accessToken is valid (even if expired) and the refresh token is still valid (which holds for 30 days).

On that note I wanted to suggest a small improvement, we should add a "remember me" checkmark on the login modal and if that is checked persist the refresh token, otherwise skip holding onto the refresh token.

@chriswhong chriswhong added feat and removed bug Something isn't working labels Dec 22, 2021
@chriswhong chriswhong changed the title Audit and Improve Auth Add a "remember me" checkbox to the login modal Dec 22, 2021
@chriswhong chriswhong changed the title Add a "remember me" checkbox to the login modal [auth] Add a "remember me" checkbox to the login modal Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants