refactor(render): remove limit, offset, all parmeters

No longer needed. Instead templates specify which components of a dataset they need

BREAKING CHANGE:
qri render limit, offset, all parameters have been removed

api/render.go

@@ -31,10 +31,6 @@ func (h *RenderHandlers) RenderHandler(w http.ResponseWriter, r *http.Request) {
 	p := &lib.RenderParams{
 		Ref:            HTTPPathToQriPath(r.URL.Path[len("/render"):]),
 		TemplateFormat: "html",
-		// TODO - parameterize
-		All:    true,
-		Limit:  0,
-		Offset: 0,
 	}
 
 	data := []byte{}

base/render.go

@@ -77,7 +77,7 @@ func AddDefaultViz(ds *dataset.Dataset) {
 }
 
 // Render executes a template for a dataset, returning a slice of HTML
-func Render(r repo.Repo, ref repo.DatasetRef, tmplData []byte, limit, offset int, all bool) ([]byte, error) {
+func Render(r repo.Repo, ref repo.DatasetRef, tmplData []byte) ([]byte, error) {
 	const tmplName = "template"
 
 	store := r.Store()

base/render_test.go

@@ -8,9 +8,8 @@ func TestRender(t *testing.T) {
 	r := newTestRepo(t)
 	ref := addCitiesDataset(t, r)
 
-	_, err := Render(r, ref, nil, 0, 0, true)
+	_, err := Render(r, ref, nil)
 	if err != nil {
-		panic(err)
 		t.Error(err.Error())
 	}
 

cmd/render.go

@@ -43,9 +43,6 @@ provided, Qri will render the dataset with a default template.`,
 
 	cmd.Flags().StringVarP(&o.Template, "template", "t", "", "path to template file")
 	cmd.Flags().StringVarP(&o.Output, "output", "o", "", "path to write output file")
-	cmd.Flags().BoolVarP(&o.All, "all", "a", false, "read all dataset entries (overrides limit, offest)")
-	cmd.Flags().IntVarP(&o.Limit, "limit", "l", 50, "max number of records to read")
-	cmd.Flags().IntVarP(&o.Offset, "offset", "s", 0, "number of records to skip")
 
 	return cmd
 }
@@ -57,9 +54,6 @@ type RenderOptions struct {
 	Ref      string
 	Template string
 	Output   string
-	All      bool
-	Limit    int
-	Offset   int
 
 	RenderRequests *lib.RenderRequests
 }
@@ -88,9 +82,6 @@ func (o *RenderOptions) Run() (err error) {
 		Ref:            o.Ref,
 		Template:       template,
 		TemplateFormat: "html",
-		All:            o.All,
-		Limit:          o.Limit,
-		Offset:         o.Offset,
 	}
 
 	res := []byte{}

lib/render.go

@@ -36,8 +36,6 @@ type RenderParams struct {
 	Ref            string
 	Template       []byte
 	TemplateFormat string
-	All            bool
-	Limit, Offset  int
 }
 
 // Render executes a template against a template
@@ -61,6 +59,6 @@ func (r *RenderRequests) Render(p *RenderParams, res *[]byte) (err error) {
 		return err
 	}
 
-	*res, err = base.Render(r.repo, ref, p.Template, p.Limit, p.Offset, p.All)
+	*res, err = base.Render(r.repo, ref, p.Template)
 	return err
 }