Skip to content

Commit

Permalink
fix(export): handle ok-case of bad viz while connected
Browse files Browse the repository at this point in the history
this was an incomplete fix to #1161

while running qri connect we need to properly handle the context deadline for a missing
viz by ignoring the error.
  • Loading branch information
b5 committed Apr 20, 2020
1 parent 30ad2de commit 1bb2463
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion base/archive/zip.go
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import (
"bytes"
"context"
"encoding/json"
"errors"
"fmt"
"io"
"io/ioutil"
Expand Down Expand Up @@ -95,7 +96,11 @@ func WriteZip(ctx context.Context, store cafs.Filestore, ds *dataset.Dataset, fo

if ds.Viz.RenderedPath != "" {
if err = maybeWriteRenderedViz(ctx, store, zw, ds.Viz.RenderedPath); err != nil {
return err
if errors.Is(err, context.DeadlineExceeded) {
err = nil
} else {
return err
}
}
}
}
Expand Down

0 comments on commit 1bb2463

Please sign in to comment.