Skip to content

Commit

Permalink
fix(api/list): fix/add pagination for api /list endpoint
Browse files Browse the repository at this point in the history
  • Loading branch information
ramfox committed Apr 29, 2019
1 parent 748e58b commit 6187c09
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 14 deletions.
19 changes: 5 additions & 14 deletions api/datasets.go
Original file line number Diff line number Diff line change
Expand Up @@ -583,6 +583,8 @@ func (h DatasetHandlers) bodyHandler(w http.ResponseWriter, r *http.Request) {
return
}

listParams := lib.ListParamsFromRequest(r)

err = repo.CanonicalizeDatasetRef(h.repo, &d)
if err != nil && err != repo.ErrNotFound {
util.WriteErrResponse(w, http.StatusInternalServerError, err)
Expand All @@ -601,24 +603,13 @@ func (h DatasetHandlers) bodyHandler(w http.ResponseWriter, r *http.Request) {
return
}

limit, err := util.ReqParamInt("limit", r)
if err != nil {
limit = defaultDataLimit
err = nil
}
offset, err := util.ReqParamInt("offset", r)
if err != nil {
offset = 0
err = nil
}

p := &lib.GetParams{
Path: d.String(),
Format: format,
Selector: "body",
Limit: limit,
Offset: offset,
All: r.FormValue("all") == "true" && limit == defaultDataLimit && offset == 0,
Limit: listParams.Limit,
Offset: listParams.Offset,
All: r.FormValue("all") == "true" && listParams.Limit == defaultDataLimit && listParams.Offset == 0,
}

result := &lib.GetResult{}
Expand Down
Binary file modified api/testdata/api.snapshot
Binary file not shown.

0 comments on commit 6187c09

Please sign in to comment.