feat(api published): GET /publish/ now lists published datasets

qri-io · Oct 29, 2018 · 6c8f0b2 · 6c8f0b2
1 parent 3d1b4bf
commit 6c8f0b2
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 1 deletion.
diff --git a/api/dataset_test.go b/api/dataset_test.go
@@ -71,6 +71,7 @@ func TestDatasetHandlers(t *testing.T) {
 
  publishCases := []handlerTestCase{
  {"OPTIONS", "/", nil},
+ {"GET", "/publish/", nil},
  {"POST", "/publish/me/cities", nil},
  {"DELETE", "/publish/me/cities", nil},
  }

diff --git a/api/datasets.go b/api/datasets.go
@@ -187,7 +187,7 @@ func (h *DatasetHandlers) PublishHandler(w http.ResponseWriter, r *http.Request)
  case "OPTIONS":
  util.EmptyOkHandler(w, r)
  case "GET":
- // TODO - this should list published datasets
+ h.listPublishedHandler(w, r)
  case "POST":
  h.publishHandler(w, r, true)
  case "DELETE":
@@ -254,6 +254,22 @@ func (h *DatasetHandlers) listHandler(w http.ResponseWriter, r *http.Request) {
  }
 }
 
+func (h *DatasetHandlers) listPublishedHandler(w http.ResponseWriter, r *http.Request) {
+ args := lib.ListParamsFromRequest(r)
+ args.OrderBy = "created"
+ args.Published = true
+
+ res := []repo.DatasetRef{}
+ if err := h.List(&args, &res); err != nil {
+ log.Infof("error listing datasets: %s", err.Error())
+ util.WriteErrResponse(w, http.StatusInternalServerError, err)
+ return
+ }
+ if err := util.WritePageResponse(w, res, r, args.Page()); err != nil {
+ log.Infof("error list datasests response: %s", err.Error())
+ }
+}
+
 func (h *DatasetHandlers) getHandler(w http.ResponseWriter, r *http.Request) {
  res := &repo.DatasetRef{}
  args, err := DatasetRefFromPath(r.URL.Path)

diff --git a/api/testdata/api.snapshot b/api/testdata/api.snapshot