fix(actions.SaveDataset): delay inferring values until after writing …

…changes

based on the set-value cascade, inference should be the last thing that occurs in the dataset creation step, only adding
vital missing components that are required by the provided state but not present

actions/dataset.go

@@ -53,11 +53,6 @@ func SaveDataset(node *p2p.QriNode, changes *dataset.Dataset, secrets map[string
  node.LocalStreams.Print("✅ transform complete\n")
  }
 
- // Infer any values about the incoming change before merging it with the previous version.
- if err = base.InferValues(pro, changes); err != nil {
- return
- }
-
  if prevPath == "" && changes.BodyFile() == nil && changes.Structure == nil {
  err = fmt.Errorf("creating a new dataset requires a structure or a body")
  return
@@ -84,6 +79,10 @@ func SaveDataset(node *p2p.QriNode, changes *dataset.Dataset, secrets map[string
  mutable.Assign(changes)
  changes = mutable
 
+ if err = base.InferValues(pro, changes); err != nil {
+ return
+ }
+
  // let's make history, if it exists:
  changes.PreviousPath = prevPath
 

lib/diff_test.go

@@ -78,20 +78,20 @@ func TestDatasetRequestsDiff(t *testing.T) {
  {"two fully qualified references",
  dsRef1.String(), dsRef2.String(),
  "",
- &DiffStat{Left: 42, Right: 44, LeftWeight: 2570, RightWeight: 2910, Inserts: 1, Updates: 9, Deletes: 0, Moves: 0},
- 10,
+ &DiffStat{Left: 42, Right: 44, LeftWeight: 2570, RightWeight: 2807, Inserts: 1, Updates: 7, Deletes: 0, Moves: 0},
+ 8,
  },
  {"fill left path from history",
  "", dsRef2.AliasString(),
  "",
- &DiffStat{Left: 42, Right: 44, LeftWeight: 2570, RightWeight: 2910, Inserts: 1, Updates: 9, Deletes: 0, Moves: 0},
- 10,
+ &DiffStat{Left: 42, Right: 44, LeftWeight: 2570, RightWeight: 2807, Inserts: 1, Updates: 7, Deletes: 0, Moves: 0},
+ 8,
  },
  {"populate from selected references",
  "", "",
  "",
- &DiffStat{Left: 42, Right: 44, LeftWeight: 2570, RightWeight: 2910, Inserts: 1, Updates: 9, Deletes: 0, Moves: 0},
- 10,
+ &DiffStat{Left: 42, Right: 44, LeftWeight: 2570, RightWeight: 2807, Inserts: 1, Updates: 7, Deletes: 0, Moves: 0},
+ 8,
  },
  {"two local file paths",
  "testdata/jobs_by_automation/body.csv", "testdata/jobs_by_automation_2/body.csv",