fix(save): reset the meta and structure paths after assign

now that we have the handy new SetPath function, we can reset the meta and structure paths after assign. assign clobbers the changed paths with the previous paths. this means that the datasetDiffer will assume no changes have been made in the meta or structure. we want the datasetDiffer to have to check each field, so we reset the path

Author: ramfox

api/middleware.go

@@ -9,7 +9,7 @@ import (
 // middleware handles request logging
 func (s *Server) middleware(handler http.HandlerFunc) http.HandlerFunc {
 	return func(w http.ResponseWriter, r *http.Request) {
-		s.log.Infof("%s %s %s", r.Method, r.URL.Path, time.Now())
+		s.log.Infof("%s %s %s\n", r.Method, r.URL.Path, time.Now())
 
 		// If this server is operating behind a proxy, but we still want to force
 		// users to use https, cfg.ProxyForceHttps == true will listen for the common

core/datasets.go

@@ -456,9 +456,14 @@ func (r *DatasetRequests) Save(p *SaveParams, res *repo.DatasetRef) (err error)
 		ds.Commit.Message = ""
 	}
 
-	// TODO - error here, since Meta and Structure don't have paths
-	// When we use the Assign() function, we clobber their paths
-	// with the old paths
+	// Assign will assign any previous paths to the current paths
+	// the datasetDiffer (called in dsfs.CreateDataset), will compare the paths
+	// see that they are the same, and claim there are no differences
+	// since we will potentially have changes in the Meta and Structure
+	// we want the differ to have to compare each field
+	// so we reset the paths
+	ds.Meta.SetPath("")
+	ds.Structure.SetPath("")
 
 	dataf = memfs.NewMemfileBytes("data."+st.Format.String(), data)
 	dspath, err := r.repo.CreateDataset(ds, dataf, true)