fix(cmd/get): must catch DatasetRequest error

qri-io · Apr 23, 2019 · f200acc · f200acc
1 parent 2239c35
commit f200acc
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 4 deletions.
diff --git a/cmd/get.go b/cmd/get.go
@@ -84,7 +84,9 @@ func (o *GetOptions) Complete(f Factory, args []string) (err error) {
 		}
 	}
 	o.Refs = args
-	o.DatasetRequests, err = f.DatasetRequests()
+	if o.DatasetRequests, err = f.DatasetRequests(); err != nil {
+		return
+	}
 
 	if o.Selector == "body" {
 		// if we have a limit, but not offset, assume an offset of 0

diff --git a/cmd/publish.go b/cmd/publish.go
@@ -65,7 +65,9 @@ type PublishOptions struct {
 // Complete adds any missing configuration that can only be added just before calling Run
 func (o *PublishOptions) Complete(f Factory, args []string) (err error) {
 	o.Refs = args
-	o.DatasetRequests, err = f.DatasetRequests()
+	if o.DatasetRequests, err = f.DatasetRequests(); err != nil {
+		return err
+	}
 	o.RemoteRequests, err = f.RemoteRequests()
 	return
 }

diff --git a/cmd/remove.go b/cmd/remove.go
@@ -64,8 +64,7 @@ type RemoveOptions struct {
 // Complete adds any missing configuration that can only be added just before calling Run
 func (o *RemoveOptions) Complete(f Factory, args []string) (err error) {
 	o.Args = args
-	o.DatasetRequests, err = f.DatasetRequests()
-	if err != nil {
+	if o.DatasetRequests, err = f.DatasetRequests(); err != nil {
 		return err
 	}
 	if o.All {