feat(keystore): keystore implmenetation #1602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b5
reviewed
Jan 15, 2021
Arqu
force-pushed
the
arqu/keystore
branch
4 times, most recently
from
652bee2
to
86b30ce
Compare
Arqu
commented
Jan 15, 2021
profile/profile.go
Outdated
| @@ -143,6 +152,7 @@ func (p Profile) Encode() (*config.ProfilePod, error) { | |||
| for _, maddr := range p.NetworkAddrs { | |||
| addrs = append(addrs, maddr.String()) | |||
| } | |||
| // TODO(aqru): see if we should also show pubkey/keyID here | |||
There was a problem hiding this comment.
@b5 This is still TODO before I merge
There was a problem hiding this comment.
@dustmop any opinion on this?
There was a problem hiding this comment.
I think this is a no? We have the profileID, and can use that to look up the key{public,id} from the keystore. No reason to store it twice, better to keep it normalized.
dustmop
reviewed
Jan 16, 2021
Arqu
force-pushed
the
arqu/keystore
branch
3 times, most recently
from
4c871c6
to
c7a9a6c
Compare
dustmop
approved these changes
Jan 19, 2021
profile/profile.go
Outdated
| @@ -143,6 +152,7 @@ func (p Profile) Encode() (*config.ProfilePod, error) { | |||
| for _, maddr := range p.NetworkAddrs { | |||
| addrs = append(addrs, maddr.String()) | |||
| } | |||
| // TODO(aqru): see if we should also show pubkey/keyID here | |||
There was a problem hiding this comment.
I think this is a no? We have the profileID, and can use that to look up the key{public,id} from the keystore. No reason to store it twice, better to keep it normalized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.