Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dispatch should be able to call http rpc using GET in addition to POST #1658

Closed
dustmop opened this issue Mar 2, 2021 · 1 comment
Closed
Labels
RPC remote procedure call issues

Comments

@dustmop
Copy link
Contributor

dustmop commented Mar 2, 2021

TODO from dispatch PR: https://github.com/qri-io/qri/pull/1653/files
// TODO(dustmop): This is always using the "POST" verb currently. We need some
// mechanism of tagging methods as being read-only and "GET"-able. Once that
// exists, use it here to lookup the verb that should be used to invoke the rpc.

The dispatch function always calls http endpoints using POST. We should add a function to MethodSets called Mapping, which includes information about whether methods can be called using GET instead of POST.

@dustmop dustmop added the RPC remote procedure call issues label Mar 2, 2021
@ramfox ramfox mentioned this issue Apr 8, 2021
29 tasks
@ramfox
Copy link
Member

ramfox commented Apr 8, 2021

Closing this issue, b/c we have since decided that the rpc will only operate via POST using json.

@ramfox ramfox closed this as completed Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RPC remote procedure call issues
Projects
None yet
Development

No branches or pull requests

2 participants