Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal data structures should serialize to disk after dispatch completes #1661

Open
dustmop opened this issue Mar 2, 2021 · 0 comments
Open

Comments

@dustmop
Copy link
Contributor

dustmop commented Mar 2, 2021

TODO from dispatch PR: https://github.com/qri-io/qri/pull/1653/files
// TODO(dustmop): If the method wrote to our internal data structures, like
// refstore, logbook, etc, serialize and commit those changes here

As dispatch is the synchronization mechanism for requests that may be running in parallel, it should also be handling changes to our internal data structures (logbook, refstore, dscache, profileStore, keyStore, etc). This allows changing data structures safely while read-only requests are running, without those requests having their data change underneath them while they are still executing, which would lead to incomprehensible bugs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant