Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(JSON): support JSON as a first-class citizen in qri #271

Merged
merged 5 commits into from
Feb 19, 2018
Merged

Conversation

b5
Copy link
Member

@b5 b5 commented Feb 19, 2018

closes #267.

this proves qri can do JSON. We've also added the capacity to have
the top level of a dataset be an object.

unfortunately, it looks like I've shipped a small regression in
dataset schema detection, which seems to now point out booleans
as strings. I'll file an issue and fix.
@b5 b5 requested review from osterbit and ramfox February 19, 2018 21:12
@ghost ghost assigned b5 Feb 19, 2018
@ghost ghost added the in progress label Feb 19, 2018
Copy link
Contributor

@osterbit osterbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍

@b5 b5 merged commit 6dee242 into master Feb 19, 2018
@ghost ghost removed the in progress label Feb 19, 2018
@b5 b5 deleted the json_support branch February 19, 2018 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix bugs, ship features, and add tests that round out support for JSON data
2 participants