-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add flags to qri save
for setting individual components of a save
#690
Comments
I'm not a huge of having a flag for each component, leads to too many flags that are similar things but are also mutually exclusive. I would prefer |
In the alternative you're outlining I would do Agreed on the many/too many flags issue. I want to make sure I understand the alternative, but for I can see this adding up to overloading the
This would have a few implications:
What about dropping the
I like this approach more b/c all I have to think about is the Toughts? cc @camhunt |
Yes, this was the possibility I was thinking of.
I think this is an even better idea. Also, we can allow changing multiple components by passing multiple
To do this we would change |
so looks like we only have to get the multiple |
This is working now, closing this issue. |
I'm having a semi-frustrating time always having to create a
dataset.yaml
ordataset.json
just to update a transform script. What I'd like to be able to do from the CLI is one of two things. The first would be providing json/yaml snippits for each component. In each of these cases the_file
argument would be a file that only defines that component, not an entire dataset:The second would be providing a raw script as a file as a shortcut for "default settings, but with this file":
qri save --transform tf_file.star me/dataset
ditto for viz scripts:
qri save --viz template_file.html me/dataset
This would just do the right thing, populating a component with defaults (like setting
syntax
tohtml
orstarlark
) and setting thescriptPath
to the supplied path argumentIn a later PR it'd be great to leverage the
qri
values we embed into datasets to intelligently accept a dataset.json definition, but if passed to a specific component argument, we would traverse to and only use that component of the supplied dataset. For example this:would be the same as saying "I've exported some other dataset as
other_dataset.json
, please copy it'smeta
component ontome/dataset
. This is future work. For now it'd be great if we errored if you passed a file that had"qri": "ds"
in the top level to any component argumentThe text was updated successfully, but these errors were encountered: