fix(setup): load plugins before attempting to setup IPFS #795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
need to load plugins before attempting to configure IPFS, flatfs is specified as part of the default IPFS configuration, but all flatfs code is loaded as a plugin. ¯\_(ツ)_/¯ This works without anything present in the /.ipfs/plugins/ directory b/c the default plugin set is complied into go-ipfs (and subsequently, the qri binary) by default Our tests missed this because the test suite needs to load all plugins to run tests in the first place. This is going to be particularly tough to test. We'll need to either: * figure out a way to cleanly unload all plugins in IPFS * use an "external" test of some sort We should do some research into plugin unloading, we could also consider using a higher level package to test the "final" setup behaviour, which may not call plugin loading at initialization time.
b5
added
fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
need to load plugins before attempting to configure IPFS, flatfs is
specified as part of the default IPFS configuration, but all flatfs
code is loaded as a plugin. ¯_(ツ)_/¯
This works without anything present in the /.ipfs/plugins/ directory b/c the default plugin set is complied into go-ipfs (and subsequently, the qri binary) by default
Our tests missed this because the test suite needs to load all plugins to run
tests in the first place. This is going to be particularly tough to test.
We'll need to either:
We should do some research into plugin unloading, we could also consider using a higher level package to test the "final" setup behaviour, which may not call plugin loading at initialization time.